[Libreoffice-commits] core.git: compilerplugins/clang fpicker/source

[Noel Grandin (via logerrit)]

 compilerplugins/clang/virtualdead.unusedparams.results |    3 ---
 fpicker/source/office/OfficeFilePicker.cxx             |    4 ++--
 fpicker/source/office/RemoteFilesDialog.cxx            |    2 +-
 fpicker/source/office/RemoteFilesDialog.hxx            |    2 +-
 fpicker/source/office/fpdialogbase.hxx                 |    2 +-
 fpicker/source/office/iodlg.cxx                        |    2 +-
 fpicker/source/office/iodlg.hxx                        |    2 +-
 7 files changed, 7 insertions(+), 10 deletions(-)

New commits:
commit f0f9d986e38c83ffc9fbc16cef461398231756aa
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Fri Oct 18 15:37:10 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Oct 21 18:12:52 2019 +0200

    loplugin:virtualdead unused param in SvtFileDialog_Base
    
    Change-Id: Id10c6df2a9d00f19dc1dc314515fedbe90918f66
    Reviewed-on: https://gerrit.libreoffice.org/81235
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 90a168fee2d6..685ee43e2b3c 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -73,9 +73,6 @@ forms/source/richtext/textattributelistener.hxx:32
 forms/source/richtext/textattributelistener.hxx:44
     void frm::ITextSelectionListener::onSelectionChanged(const struct ESelection &,)
     0
-fpicker/source/office/fpdialogbase.hxx:106
-    void SvtFileDialog_Base::setImage(short,const class com::sun::star::uno::Any &,)
-    01
 include/canvas/base/bufferedgraphicdevicebase.hxx:230
     void canvas::BufferedGraphicDeviceBase::windowShown(const struct com::sun::star::lang::EventObject &,)
     0
diff --git a/fpicker/source/office/OfficeFilePicker.cxx b/fpicker/source/office/OfficeFilePicker.cxx
index 0d453066ed6b..aa95fcc8baf2 100644
--- a/fpicker/source/office/OfficeFilePicker.cxx
+++ b/fpicker/source/office/OfficeFilePicker.cxx
@@ -840,13 +840,13 @@ sal_Int32 SAL_CALL SvtFilePicker::getAvailableHeight()
 }
 
 
-void SAL_CALL SvtFilePicker::setImage( sal_Int16 aImageFormat, const Any& rImage )
+void SAL_CALL SvtFilePicker::setImage( sal_Int16 /*aImageFormat*/, const Any& rImage )
 {
     checkAlive();
 
     SolarMutexGuard aGuard;
     if ( getDialog() )
-        getDialog()->setImage( aImageFormat, rImage );
+        getDialog()->setImage( rImage );
 }
 
 
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx
index a2f8ffb63631..688f85aff6f7 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -1497,7 +1497,7 @@ sal_Int32 RemoteFilesDialog::getAvailableHeight()
     return 0;
 }
 
-void RemoteFilesDialog::setImage( sal_Int16, const css::uno::Any& )
+void RemoteFilesDialog::setImage( const css::uno::Any& )
 {
     // This dialog doesn't contain preview
 }
diff --git a/fpicker/source/office/RemoteFilesDialog.hxx b/fpicker/source/office/RemoteFilesDialog.hxx
index e37e9a37f7e4..f78b2b51c820 100644
--- a/fpicker/source/office/RemoteFilesDialog.hxx
+++ b/fpicker/source/office/RemoteFilesDialog.hxx
@@ -108,7 +108,7 @@ public:
     virtual sal_Int32 getAvailableWidth() override;
     virtual sal_Int32 getAvailableHeight() override;
 
-    virtual void setImage( sal_Int16 aImageFormat, const css::uno::Any& rImage ) override;
+    virtual void setImage( const css::uno::Any& rImage ) override;
 
     virtual bool getShowState() override;
 
diff --git a/fpicker/source/office/fpdialogbase.hxx b/fpicker/source/office/fpdialogbase.hxx
index 5b921b9379d0..575f4acd5aab 100644
--- a/fpicker/source/office/fpdialogbase.hxx
+++ b/fpicker/source/office/fpdialogbase.hxx
@@ -103,7 +103,7 @@ public:
     virtual sal_Int32 getAvailableWidth() = 0;
     virtual sal_Int32 getAvailableHeight() = 0;
 
-    virtual void setImage( sal_Int16 aImageFormat, const css::uno::Any& rImage ) = 0;
+    virtual void setImage( const css::uno::Any& rImage ) = 0;
 
     virtual bool getShowState() = 0;
 };
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index 332b345b36bd..97d64381d154 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -2583,7 +2583,7 @@ sal_Int32 SvtFileDialog::getAvailableHeight()
 }
 
 
-void SvtFileDialog::setImage( sal_Int16 /*aImageFormat*/, const Any& rImage )
+void SvtFileDialog::setImage( const Any& rImage )
 {
     if ( ! _pPrevBmp || ! _pPrevBmp->IsVisible() )
         return;
diff --git a/fpicker/source/office/iodlg.hxx b/fpicker/source/office/iodlg.hxx
index 83a639bfa279..9a4af4c35541 100644
--- a/fpicker/source/office/iodlg.hxx
+++ b/fpicker/source/office/iodlg.hxx
@@ -213,7 +213,7 @@ public:
     sal_Int32                   getTargetColorDepth() override;
     sal_Int32                   getAvailableWidth() override;
     sal_Int32                   getAvailableHeight() override;
-    void                        setImage( sal_Int16 aImageFormat, const css::uno::Any& rImage ) override;
+    void                        setImage( const css::uno::Any& rImage ) override;
     bool                        getShowState() override;
     bool                        isAutoExtensionEnabled() const;