[Libreoffice-commits] core.git: basic/source

Mike Kaganski (via logerrit) logerrit at kemper.freedesktop.org
Tue Oct 22 04:51:14 UTC 2019


 basic/source/runtime/stdobj1.cxx |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 2008880a57754c5e54625b06fb9a1a23a848a617
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Mon Oct 21 11:27:11 2019 +0300
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Tue Oct 22 06:50:38 2019 +0200

    These should be sal_Int16
    
    Change-Id: I18112d114c4632961b86da5539959c0d4abd79c7
    Reviewed-on: https://gerrit.libreoffice.org/81276
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/basic/source/runtime/stdobj1.cxx b/basic/source/runtime/stdobj1.cxx
index f648ea1a7fa0..039be508aef9 100644
--- a/basic/source/runtime/stdobj1.cxx
+++ b/basic/source/runtime/stdobj1.cxx
@@ -295,8 +295,8 @@ void SbStdClipboard::MethGetData( SbxArray* pPar_ )
         return;
     }
 
-    sal_uInt16 nFormat = pPar_->Get(1)->GetInteger();
-    if( !nFormat  || nFormat > 3 )
+    sal_Int16 nFormat = pPar_->Get(1)->GetInteger();
+    if( nFormat <= 0 || nFormat > 3 )
     {
         StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
         return;
@@ -312,8 +312,8 @@ void SbStdClipboard::MethGetFormat( SbxVariable* pVar, SbxArray* pPar_ )
         return;
     }
 
-    sal_uInt16 nFormat = pPar_->Get(1)->GetInteger();
-    if( !nFormat  || nFormat > 3 )
+    sal_Int16 nFormat = pPar_->Get(1)->GetInteger();
+    if( nFormat <= 0 || nFormat > 3 )
     {
         StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
         return;
@@ -341,8 +341,8 @@ void SbStdClipboard::MethSetData( SbxArray* pPar_ )
         return;
     }
 
-    sal_uInt16 nFormat = pPar_->Get(2)->GetInteger();
-    if( !nFormat  || nFormat > 3 )
+    sal_Int16 nFormat = pPar_->Get(2)->GetInteger();
+    if( nFormat <= 0 || nFormat > 3 )
     {
         StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
         return;


More information about the Libreoffice-commits mailing list