[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - svtools/qa svtools/source

Henry Castro (via logerrit) logerrit at kemper.freedesktop.org
Wed Oct 23 15:46:36 UTC 2019


 svtools/qa/unit/svtools-dialogs-test.cxx |    2 +-
 svtools/source/uitest/uiobject.cxx       |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 4f756a6b06d9bac0b557852eb72d654f3facf244
Author:     Henry Castro <hcastro at collabora.com>
AuthorDate: Wed Oct 23 09:26:10 2019 -0400
Commit:     Henry Castro <hcastro at collabora.com>
CommitDate: Wed Oct 23 17:45:43 2019 +0200

    lok: svtools: change parameter from "ID" to "POS" in ValueSetUIObject class
    
    The ValueSet control has an item list with a pair properties "(pos,id)".
    The "POS" parameter is the item "ID" not the position in the list and
    to not modify doc_sendDialogEvent function, let's have same uniform
    parameter for the action "SELECT".
    
    Change-Id: I5ce2cf0433bebcd77954f271c4aa09b0b446c0ab
    Reviewed-on: https://gerrit.libreoffice.org/81387
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Henry Castro <hcastro at collabora.com>

diff --git a/svtools/qa/unit/svtools-dialogs-test.cxx b/svtools/qa/unit/svtools-dialogs-test.cxx
index 692453335794..fd1cf31b31cc 100644
--- a/svtools/qa/unit/svtools-dialogs-test.cxx
+++ b/svtools/qa/unit/svtools-dialogs-test.cxx
@@ -84,7 +84,7 @@ void SvtoolsDialogsTest::testValueSetControl()
         CPPUNIT_ASSERT(pUIObject);
 
         StringMap aMap;
-        aMap["ID"] = "300";
+        aMap["POS"] = "300";
 
         pUIObject->execute("SELECT", aMap);
     }
diff --git a/svtools/source/uitest/uiobject.cxx b/svtools/source/uitest/uiobject.cxx
index 4d78e618dad2..a07a5158349b 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -67,9 +67,9 @@ void ValueSetUIObject::execute(const OUString& rAction,
 
     if (rAction == "SELECT")
     {
-        if (rParameters.find("ID") != rParameters.end())
+        if (rParameters.find("POS") != rParameters.end())
         {
-            auto aPos = rParameters.find("ID");
+            auto aPos = rParameters.find("POS");
             OUString aVal = aPos->second;
             sal_Int32 nPos = aVal.toInt32();
             mxValueSet->SelectItem(nPos);


More information about the Libreoffice-commits mailing list