[Libreoffice-commits] core.git: svtools/qa svtools/source
Henry Castro (via logerrit)
logerrit at kemper.freedesktop.org
Wed Oct 23 17:36:47 UTC 2019
svtools/qa/unit/svtools-dialogs-test.cxx | 2 +-
svtools/source/uitest/uiobject.cxx | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 7220d958b392eabc51236a31be549df8fa3007c0
Author: Henry Castro <hcastro at collabora.com>
AuthorDate: Wed Oct 23 09:26:10 2019 -0400
Commit: Henry Castro <hcastro at collabora.com>
CommitDate: Wed Oct 23 19:34:51 2019 +0200
lok: svtools: change parameter from "ID" to "POS" in ValueSetUIObject class
The ValueSet control has an item list with a pair properties "(pos,id)".
The "POS" parameter is the item "ID" not the position in the list and
to not modify doc_sendDialogEvent function, let's have same uniform
parameter for the action "SELECT".
Change-Id: I5ce2cf0433bebcd77954f271c4aa09b0b446c0ab
Reviewed-on: https://gerrit.libreoffice.org/81399
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro at collabora.com>
diff --git a/svtools/qa/unit/svtools-dialogs-test.cxx b/svtools/qa/unit/svtools-dialogs-test.cxx
index 897455b2ff23..f710217ea7fd 100644
--- a/svtools/qa/unit/svtools-dialogs-test.cxx
+++ b/svtools/qa/unit/svtools-dialogs-test.cxx
@@ -81,7 +81,7 @@ void SvtoolsDialogsTest::testValueSetControl()
CPPUNIT_ASSERT(pUIObject);
StringMap aMap;
- aMap["ID"] = "300";
+ aMap["POS"] = "300";
pUIObject->execute("SELECT", aMap);
}
diff --git a/svtools/source/uitest/uiobject.cxx b/svtools/source/uitest/uiobject.cxx
index 2b1933a19e21..0e0df658f06a 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -27,9 +27,9 @@ void ValueSetUIObject::execute(const OUString& rAction, const StringMap& rParame
if (rAction == "SELECT")
{
- if (rParameters.find("ID") != rParameters.end())
+ if (rParameters.find("POS") != rParameters.end())
{
- auto aPos = rParameters.find("ID");
+ auto aPos = rParameters.find("POS");
OUString aVal = aPos->second;
sal_Int32 nPos = aVal.toInt32();
mxValueSet->SelectItem(nPos);
More information about the Libreoffice-commits
mailing list