[Libreoffice-commits] core.git: extensions/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Oct 24 21:11:49 UTC 2019


 extensions/source/ole/unoobjw.cxx |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 628a64895455efe2252fecdee270d08987e295c1
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Oct 24 17:57:31 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Oct 24 23:09:53 2019 +0200

    Make this SAL_INFO less elaborate
    
    ...but simpler code.  (These SAL_INFOs here started with
    2b6a84c8f699c9da115ce297ad19b8f480ab608f "We might need to handle form controls
    as properties for OLE clients after all", and look like they were likely just a
    temporary debuggin tool anyway?)
    
    Change-Id: Id8dce87de639cbc4a649a8e5478798fdcdedf1b5
    Reviewed-on: https://gerrit.libreoffice.org/81467
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/extensions/source/ole/unoobjw.cxx b/extensions/source/ole/unoobjw.cxx
index 0c67f4813263..436feb3097e9 100644
--- a/extensions/source/ole/unoobjw.cxx
+++ b/extensions/source/ole/unoobjw.cxx
@@ -1147,18 +1147,14 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP InterfaceOleWrapper::GetIDsOfNames(REFIID /*ri
     if( ! rgdispid)
         return E_POINTER;
 
-    OUString sNames("[");
+    SAL_INFO("extensions.olebridge", this << "@InterfaceOleWrapper::GetIDsOfNames:");
     for (unsigned int i = 0; i < cNames; ++i)
     {
         // Initialise returned rgdispid values.
         rgdispid[i] = DISPID_UNKNOWN;
-        if (i > 0)
-            sNames += ",";
-        sNames += OUStringLiteral("\"") + o3tl::toU(rgszNames[i]) + "\"";
-    }
-    sNames += "]";
 
-    SAL_INFO("extensions.olebridge", this << "@InterfaceOleWrapper::GetIDsOfNames(" << sNames);
+        SAL_INFO("extensions.olebridge", " " << o3tl::toU(rgszNames[i]));
+    }
 
     HRESULT ret = DISP_E_UNKNOWNNAME;
     try


More information about the Libreoffice-commits mailing list