[Libreoffice-commits] online.git: test/TileCacheTests.cpp

[Miklos Vajna (via logerrit)]

 test/TileCacheTests.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3ba17824e356db841aae2e40d07dd5c29aba9128
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Thu Oct 31 09:39:38 2019 +0100
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Thu Oct 31 09:39:45 2019 +0100

    Fix TileCacheTests::testUnresponsiveClient()
    
    This started to reliably fail for me recently.
    
    I think the problem was that deleteAll() also listened for incoming
    messages, so while waiting for textselection:, perhaps it processed (and
    ignored) invalidatetiles:.
    
    As a consequence, once deleteAll() returned and testUnresponsiveClient()
    started to wait for invalidatetiles:, the test may or may not failed,
    depending on the order of messages.
    
    Fix the problem by just dispatching the SelectAll and Delete commands,
    then waiting for invalidatetiles:.
    
    Change-Id: I33f096e7dcb7f9daf1968dcb50d8a5f53824f5bd

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index f9d94c6e1..0f0195b10 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -456,7 +456,8 @@ void TileCacheTests::testUnresponsiveClient()
     for (int x = 0; x < 8; ++x)
     {
         // Invalidate to force re-rendering.
-        deleteAll(socket2, testname);
+        sendTextFrame(socket2, "uno .uno:SelectAll", testname);
+        sendTextFrame(socket2, "uno .uno:Delete", testname);
         assertResponseString(socket2, "invalidatetiles:", testname + "2 ");
         sendTextFrame(socket2, "paste mimetype=text/html\n" + documentContents, testname + "2 ");
         assertResponseString(socket2, "invalidatetiles:", testname + "2 ");