[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/qa

Ashod Nakashian (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 4 19:20:18 UTC 2019


 vcl/qa/cppunit/pdfexport/pdfexport.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e0712f4339c69a0cae80585df8563fe40d152177
Author:     Ashod Nakashian <ashod.nakashian at collabora.co.uk>
AuthorDate: Wed Sep 4 11:02:25 2019 -0400
Commit:     Andras Timar <andras.timar at collabora.com>
CommitDate: Wed Sep 4 21:19:41 2019 +0200

    pdfexport: improved detection of failure to print with --disable-gui
    
    PDF printing tests cannot run when we don't have the proper
    support enabled, so we need to detect those cases and
    avoid failing the test unnecessarily.
    
    Change-Id: Ia602dbb5c3d16c082a8ff6e707db90501bb5453c
    Reviewed-on: https://gerrit.libreoffice.org/78610
    Reviewed-by: Andras Timar <andras.timar at collabora.com>
    Tested-by: Andras Timar <andras.timar at collabora.com>

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index bcc4d11d1682..03f412016f6e 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -638,7 +638,7 @@ void PdfExportTest::testSofthyphenPos()
     SvFileStream aFile(maTempFile.GetURL(), StreamMode::READ);
     SvMemoryStream aMemory;
     aMemory.WriteStream(aFile);
-    if (aFile.bad())
+    if (aFile.bad() || !aMemory.GetSize())
     {
         // Printing to PDF failed in a non-interesting way, e.g. CUPS is not
         // running, there is no printer defined, etc.


More information about the Libreoffice-commits mailing list