[Libreoffice-commits] core.git: sc/source

Mike Kaganski (via logerrit) logerrit at kemper.freedesktop.org
Tue Sep 17 09:26:02 UTC 2019


 sc/source/core/data/table3.cxx |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

New commits:
commit f57155ec6a980c6222bde4fdea6ce5a54b49025d
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sun Sep 15 15:08:12 2019 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Tue Sep 17 11:25:05 2019 +0200

    OUStringBuffer use should be the other way round here
    
    Change-Id: I0555f619253268c71187c24fa7336d44b3fe4dd2
    Reviewed-on: https://gerrit.libreoffice.org/78928
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 94a84b0cf941..64596e2c3101 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -3101,18 +3101,15 @@ SCSIZE ScTable::Query(const ScQueryParam& rParamOrg, bool bKeepSub)
                 bResult = true;
             else
             {
-                OUString aStr;
+                OUStringBuffer aStr;
                 for (SCCOL k=aParam.nCol1; k <= aParam.nCol2; k++)
                 {
                     OUString aCellStr;
                     GetString(k, j, aCellStr);
-                    OUStringBuffer aBuf(aStr);
-                    aBuf.append(aCellStr);
-                    aBuf.append(u'\x0001');
-                    aStr = aBuf.makeStringAndClear();
+                    aStr.append(aCellStr + u"\x0001");
                 }
 
-                bResult = aStrSet.insert(aStr).second; // unique if inserted.
+                bResult = aStrSet.insert(aStr.makeStringAndClear()).second; // unique if inserted.
             }
         }
         else


More information about the Libreoffice-commits mailing list