[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vbahelper/source

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Fri Sep 20 09:18:41 UTC 2019


 vbahelper/source/vbahelper/vbadocumentsbase.cxx |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit e472b3a93e017c923564e7da12684aba87119a68
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Fri Feb 15 11:31:00 2019 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Fri Sep 20 11:17:37 2019 +0200

    Add a FIXME note
    
    Change-Id: Iedda7ca9cff1bda763845e665e0e21656b253793
    (cherry picked from commit bec67a7f0e15eb1c342e3e2fb9104ab0f3502412)
    Reviewed-on: https://gerrit.libreoffice.org/79165
    Reviewed-by: Tor Lillqvist <tml at collabora.com>
    Tested-by: Tor Lillqvist <tml at collabora.com>

diff --git a/vbahelper/source/vbahelper/vbadocumentsbase.cxx b/vbahelper/source/vbahelper/vbadocumentsbase.cxx
index d188812e89cd..7a993d7aa2cd 100644
--- a/vbahelper/source/vbahelper/vbadocumentsbase.cxx
+++ b/vbahelper/source/vbahelper/vbadocumentsbase.cxx
@@ -285,6 +285,12 @@ uno::Any VbaDocumentsBase::openDocument( const OUString& rFileName, const uno::A
         }
     }
 
+    // FIXME: Should we add an AsTemplate property with value false
+    // here, to be absolutely sure it doesn't (for some mysterious
+    // reason) open the document as a template (as happens for a .rtf
+    // file at a customer)? Nah, let's see first if I can figure out
+    // what the mysterious reason is...
+
     uno::Reference< lang::XComponent > xComponent = xDesktop->loadComponentFromURL( aURL,
         "_default" ,
         frame::FrameSearchFlag::CREATE,


More information about the Libreoffice-commits mailing list