[Libreoffice-commits] core.git: sc/source

Szymon Kłos (via logerrit) logerrit at kemper.freedesktop.org
Thu Sep 26 08:05:52 UTC 2019


 sc/source/ui/view/gridwin.cxx |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

New commits:
commit b11268fadf76618ad37d27219b7f51255f8f8b5a
Author:     Szymon Kłos <szymon.klos at collabora.com>
AuthorDate: Tue Apr 16 10:26:34 2019 +0200
Commit:     Michael Meeks <michael.meeks at collabora.com>
CommitDate: Thu Sep 26 10:04:39 2019 +0200

    Fix range selection in chart wizard for online
    
    In the Online when range was selected in second
    step of the Chart Wizard, main window become
    unresponsive. This fix blocks doubled MouseButtonUp
    event and allows to fold/unfold multiple times the
    range selection dialog by allowing to use that window
    type in SetRefDialog.
    
    Change-Id: I9f64cf7a110ab9264bc53dd740f0caf576764714
    Reviewed-on: https://gerrit.libreoffice.org/79570
    Tested-by: Jenkins
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 0bfbcce82ddf..131f744aef69 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2646,11 +2646,14 @@ void ScGridWindow::Tracking( const TrackingEvent& rTEvt )
     }
     else if ( rTEvt.IsTrackingEnded() )
     {
-        // MouseButtonUp always with matching buttons (eg for test tool, # 63148 #)
-        // The tracking event will indicate if it was completed and not canceled.
-        MouseEvent aUpEvt( rMEvt.GetPosPixel(), rMEvt.GetClicks(),
-                            rMEvt.GetMode(), nButtonDown, rMEvt.GetModifier() );
-        MouseButtonUp( aUpEvt );
+        if ( !comphelper::LibreOfficeKit::isActive() )
+        {
+            // MouseButtonUp always with matching buttons (eg for test tool, # 63148 #)
+            // The tracking event will indicate if it was completed and not canceled.
+            MouseEvent aUpEvt( rMEvt.GetPosPixel(), rMEvt.GetClicks(),
+                                rMEvt.GetMode(), nButtonDown, rMEvt.GetModifier() );
+            MouseButtonUp( aUpEvt );
+        }
     }
     else
         MouseMove( rMEvt );


More information about the Libreoffice-commits mailing list