[Libreoffice-commits] core.git: compilerplugins/clang sw/inc sw/source
Noel Grandin (via logerrit)
logerrit at kemper.freedesktop.org
Thu Sep 26 12:07:02 UTC 2019
compilerplugins/clang/virtualdead.results | 9 ---------
sw/inc/IDocumentState.hxx | 2 --
sw/source/core/doc/DocumentStateManager.cxx | 4 ----
sw/source/core/inc/DocumentStateManager.hxx | 1 -
sw/source/filter/basflt/shellio.cxx | 1 -
sw/source/ui/dbui/mmoutputtypepage.cxx | 11 -----------
sw/source/uibase/dbui/dbmgr.cxx | 2 --
sw/source/uibase/dbui/maildispatcher.cxx | 8 --------
sw/source/uibase/inc/imaildsplistener.hxx | 10 ----------
9 files changed, 48 deletions(-)
New commits:
commit 464fe63e334f697c5801d4ef0c5e4a2896d28c04
Author: Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Sep 26 08:53:44 2019 +0200
Commit: Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Sep 26 14:05:52 2019 +0200
loplugin:virtualdead in sw
Change-Id: Ib96caad8a2bbfc4ff9a5191abbd49789d142d2eb
Reviewed-on: https://gerrit.libreoffice.org/79587
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/virtualdead.results b/compilerplugins/clang/virtualdead.results
index dbe267b1ee4f..2658662aa5b6 100644
--- a/compilerplugins/clang/virtualdead.results
+++ b/compilerplugins/clang/virtualdead.results
@@ -220,18 +220,9 @@ slideshow/source/inc/slide.hxx:118
svx/source/inc/docrecovery.hxx:162
void svx::DocRecovery::IRecoveryUpdateListener::start()
empty
-sw/inc/IDocumentState.hxx:48
- void IDocumentState::SetLoaded()
- empty
sw/source/core/inc/swblocks.hxx:81
enum SwImpBlocks::FileType SwImpBlocks::GetFileType()const
3
-sw/source/uibase/inc/imaildsplistener.hxx:43
- void IMailDispatcherListener::started(class rtl::Reference<class MailDispatcher>,)
- empty
-sw/source/uibase/inc/imaildsplistener.hxx:48
- void IMailDispatcherListener::stopped(class rtl::Reference<class MailDispatcher>,)
- empty
vcl/inc/salframe.hxx:145
void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
empty
diff --git a/sw/inc/IDocumentState.hxx b/sw/inc/IDocumentState.hxx
index d108a91ccb3a..6374842bdb0f 100644
--- a/sw/inc/IDocumentState.hxx
+++ b/sw/inc/IDocumentState.hxx
@@ -45,8 +45,6 @@ public:
virtual void SetUpdateExpFieldStat(bool b) = 0;
- virtual void SetLoaded() = 0;
-
virtual bool IsEnableSetModified() const = 0;
virtual void SetEnableSetModified(bool bEnableSetModified) = 0;
diff --git a/sw/source/core/doc/DocumentStateManager.cxx b/sw/source/core/doc/DocumentStateManager.cxx
index dd78cf58f3b9..1a704c3e9980 100644
--- a/sw/source/core/doc/DocumentStateManager.cxx
+++ b/sw/source/core/doc/DocumentStateManager.cxx
@@ -113,10 +113,6 @@ void DocumentStateManager::SetUpdateExpFieldStat(bool b)
mbUpdateExpField = b;
}
-void DocumentStateManager::SetLoaded()
-{
-}
-
}
diff --git a/sw/source/core/inc/DocumentStateManager.hxx b/sw/source/core/inc/DocumentStateManager.hxx
index a4c448b543fb..e9b7d09bbc56 100644
--- a/sw/source/core/inc/DocumentStateManager.hxx
+++ b/sw/source/core/inc/DocumentStateManager.hxx
@@ -43,7 +43,6 @@ public:
bool IsNewDoc() const override;
void SetNewDoc(bool b) override;
void SetUpdateExpFieldStat(bool b) override;
- void SetLoaded() override;
private:
diff --git a/sw/source/filter/basflt/shellio.cxx b/sw/source/filter/basflt/shellio.cxx
index 37426ccd1c40..708e13c2535b 100644
--- a/sw/source/filter/basflt/shellio.cxx
+++ b/sw/source/filter/basflt/shellio.cxx
@@ -346,7 +346,6 @@ ErrCode SwReader::Read( const Reader& rOptions )
mxDoc->UpdateNumRule();
mxDoc->ChkCondColls();
mxDoc->SetAllUniqueFlyNames();
- mxDoc->getIDocumentState().SetLoaded();
// Clear unassigned cell styles, because they aren't needed anymore.
mxDoc->GetCellStyles().clear();
diff --git a/sw/source/ui/dbui/mmoutputtypepage.cxx b/sw/source/ui/dbui/mmoutputtypepage.cxx
index 83685a6692ea..d8766b8a3c9d 100644
--- a/sw/source/ui/dbui/mmoutputtypepage.cxx
+++ b/sw/source/ui/dbui/mmoutputtypepage.cxx
@@ -122,8 +122,6 @@ class SwMailDispatcherListener_Impl : public IMailDispatcherListener
public:
explicit SwMailDispatcherListener_Impl(SwSendMailDialog& rParentDlg);
- virtual void started(::rtl::Reference<MailDispatcher> xMailDispatcher) override;
- virtual void stopped(::rtl::Reference<MailDispatcher> xMailDispatcher) override;
virtual void idle(::rtl::Reference<MailDispatcher> xMailDispatcher) override;
virtual void mailDelivered(::rtl::Reference<MailDispatcher> xMailDispatcher,
uno::Reference< mail::XMailMessage> xMailMessage) override;
@@ -138,15 +136,6 @@ SwMailDispatcherListener_Impl::SwMailDispatcherListener_Impl(SwSendMailDialog& r
{
}
-void SwMailDispatcherListener_Impl::started(::rtl::Reference<MailDispatcher> /*xMailDispatcher*/)
-{
-}
-
-void SwMailDispatcherListener_Impl::stopped(
- ::rtl::Reference<MailDispatcher> /*xMailDispatcher*/)
-{
-}
-
void SwMailDispatcherListener_Impl::idle(::rtl::Reference<MailDispatcher> /*xMailDispatcher*/)
{
SolarMutexGuard aGuard;
diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index a3625e788896..d9341d8c60ea 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -1080,8 +1080,6 @@ public:
explicit MailDispatcherListener_Impl( SwDBManager &rDBManager )
: m_rDBManager( rDBManager ) {}
- virtual void started( ::rtl::Reference<MailDispatcher> ) override {};
- virtual void stopped( ::rtl::Reference<MailDispatcher> ) override {};
virtual void idle( ::rtl::Reference<MailDispatcher> ) override {};
virtual void mailDelivered( ::rtl::Reference<MailDispatcher>,
diff --git a/sw/source/uibase/dbui/maildispatcher.cxx b/sw/source/uibase/dbui/maildispatcher.cxx
index 546fd3698032..e55e61bfb8ae 100644
--- a/sw/source/uibase/dbui/maildispatcher.cxx
+++ b/sw/source/uibase/dbui/maildispatcher.cxx
@@ -152,10 +152,6 @@ void MailDispatcher::start()
m_bActive = true;
m_aWakeupCondition.set();
thread_status_guard.clear();
-
- MailDispatcherListenerContainer_t aClonedListenerVector(cloneListener());
- std::for_each( aClonedListenerVector.begin(), aClonedListenerVector.end(),
- GenericEventNotifier(&IMailDispatcherListener::started, this) );
}
}
@@ -172,10 +168,6 @@ void MailDispatcher::stop()
m_bActive = false;
m_aWakeupCondition.reset();
thread_status_guard.clear();
-
- MailDispatcherListenerContainer_t aClonedListenerVector(cloneListener());
- std::for_each( aClonedListenerVector.begin(), aClonedListenerVector.end(),
- GenericEventNotifier(&IMailDispatcherListener::stopped, this) );
}
}
diff --git a/sw/source/uibase/inc/imaildsplistener.hxx b/sw/source/uibase/inc/imaildsplistener.hxx
index 1dcf2862d981..d995662fe758 100644
--- a/sw/source/uibase/inc/imaildsplistener.hxx
+++ b/sw/source/uibase/inc/imaildsplistener.hxx
@@ -38,16 +38,6 @@ class IMailDispatcherListener : public salhelper::SimpleReferenceObject
{
public:
/**
- Called when the MailDispatcher is started.
- */
- virtual void started(::rtl::Reference<MailDispatcher> xMailDispatcher) = 0;
-
- /**
- Called when the MailDispatcher is stopped.
- */
- virtual void stopped(::rtl::Reference<MailDispatcher> xMailDispatcher) = 0;
-
- /**
Called when there are no more mail messages
to deliver.
*/
More information about the Libreoffice-commits
mailing list