[Libreoffice-commits] core.git: sc/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Sep 27 10:15:26 UTC 2019


 sc/source/ui/app/inputhdl.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d4a037a1d9e6331b7ff3423ef34b8c06530c55fc
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Sep 27 09:06:43 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Sep 27 12:13:47 2019 +0200

    cid#1454002 Dereference after null check
    
    Change-Id: I855922a70b615b8ac4de147d081d530edcc5be63
    Reviewed-on: https://gerrit.libreoffice.org/79674
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index b7f61da9fcc7..f7d04468f46b 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -3770,7 +3770,7 @@ void ScInputHandler::NotifyChange( const ScInputHdlState* pState,
     {
         ScModule* pScMod = SC_MOD();
 
-        ScTabViewShell* pScTabViewShell = pScMod ? dynamic_cast<ScTabViewShell*>(pScMod->GetViewShell()) : nullptr;
+        ScTabViewShell* pScTabViewShell = dynamic_cast<ScTabViewShell*>(pScMod->GetViewShell());
 
         // Also take foreign reference input into account here (e.g. FunctionsAutoPilot),
         // FormEditData, if we're switching from Help to Calc:


More information about the Libreoffice-commits mailing list