[Libreoffice-commits] core.git: wizards/source

Andreas Heinisch (via logerrit) logerrit at kemper.freedesktop.org
Fri Sep 27 18:28:03 UTC 2019


 wizards/source/depot/Internet.xba |   10 +++++-----
 wizards/source/tools/Misc.xba     |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 7c694158ffb6549b31c2547c82c6bd670757a53c
Author:     Andreas Heinisch <andreas.heinisch at yahoo.de>
AuthorDate: Thu Sep 26 08:39:19 2019 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Fri Sep 27 20:26:35 2019 +0200

    tdf#50846 - Wrong type of function GetLastUsedRow
    
    Changed the type of the function GetLastUsedRow from int to long
    in order to avoid overflows.
    
    Change-Id: Ia0d789611f732eecdfdbe557b751dbead5748c45
    Reviewed-on: https://gerrit.libreoffice.org/79586
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/wizards/source/depot/Internet.xba b/wizards/source/depot/Internet.xba
index 333bcf98af89..d3393bc72ae9 100644
--- a/wizards/source/depot/Internet.xba
+++ b/wizards/source/depot/Internet.xba
@@ -172,17 +172,17 @@ Sub UpdateValue(ByVal sName As String, fDate As Double, fValue As Double )
 Dim oSheet As Object
 Dim iColumn As Long
 Dim iRow As Long
-Dim i as Integer
+Dim i as Long
 Dim oCell As Object
 Dim LastDate as Date
 Dim bLeaveLoop as Boolean
-Dim RemoveCount as Integer
-Dim iLastRow as Integer
-Dim iLastLinkRow as Integer
+Dim RemoveCount as Long
+Dim iLastRow as Long
+Dim iLastLinkRow as Long
 Dim dDate as Date
 Dim CurDate as Date
 Dim oLinkSheet as Object
-Dim StartIndex as Integer
+Dim StartIndex as Long
 Dim iCellValue as Long
 	' Insert Sheet with Company - Chart
 	sName = CheckNewSheetname(oSheets, sName)
diff --git a/wizards/source/tools/Misc.xba b/wizards/source/tools/Misc.xba
index 2bf17d32e984..9b9e1dba6cda 100644
--- a/wizards/source/tools/Misc.xba
+++ b/wizards/source/tools/Misc.xba
@@ -642,7 +642,7 @@ Dim i as Integer
 End Function
 
 
-Function GetLastUsedRow(oSheet as Object) as Integer
+Function GetLastUsedRow(oSheet as Object) as Long
 Dim oCell As Object
 Dim oCursor As Object
 Dim aAddress As Variant


More information about the Libreoffice-commits mailing list