[Libreoffice-commits] core.git: sfx2/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Apr 1 13:10:07 UTC 2020


 sfx2/source/appl/workwin.cxx |   13 -------------
 1 file changed, 13 deletions(-)

New commits:
commit dfb42fe42227e99f74d592acb0f27765b4f5e2cf
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Apr 1 11:59:51 2020 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Apr 1 15:09:22 2020 +0200

    Related: tdf#131613 remove explicit UpdateSettings call
    
    it shouldn't be necessary, if the settings change the windows should
    already have been updated without this explicit loop
    
    Change-Id: Id409f17af8be1ad9412be5dfa5bdec63955f6998
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91483
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx
index 4343b7f18b87..7af0324e9b01 100644
--- a/sfx2/source/appl/workwin.cxx
+++ b/sfx2/source/appl/workwin.cxx
@@ -2448,19 +2448,6 @@ void SfxWorkWindow::SetActiveChild_Impl( vcl::Window *pChild )
 
 void SfxWorkWindow::DataChanged_Impl()
 {
-    sal_uInt16 n;
-    sal_uInt16 nCount = aChildWins.size();
-    for (n=0; n<nCount; n++)
-    {
-        SfxChildWin_Impl*pCW = aChildWins[n].get();
-        if (pCW && pCW->pWin)
-        {
-            // TODO does this really have any meaning ?
-            if (pCW->pWin->GetWindow())
-                pCW->pWin->GetWindow()->UpdateSettings(Application::GetSettings());
-        }
-    }
-
     ArrangeChildren_Impl();
 }
 


More information about the Libreoffice-commits mailing list