[Libreoffice-commits] online.git: wsd/protocol.txt

[Tor Lillqvist (via logerrit)]

 wsd/protocol.txt |    8 ++++++++
 1 file changed, 8 insertions(+)

New commits:
commit 07a3dcf65152fb5739afa4497e745e8e230670fc
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Fri Apr 3 13:46:06 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Fri Apr 3 14:54:35 2020 +0300

    Mention that parameters in some messages are actually positional
    
    Change-Id: Ifeb09f96ab43784d428f6ad1cbcdbfc27e6595c9

diff --git a/wsd/protocol.txt b/wsd/protocol.txt
index fd94c741f..40ceb0de1 100644
--- a/wsd/protocol.txt
+++ b/wsd/protocol.txt
@@ -21,6 +21,14 @@ spontaneously. For 'tile' messages, the client may send a bunch of
 tile requests without waiting for return messages. The server may send
 tiles proactively (guessing what the client might need). Etc.
 
+The original intent was that the parameters of the messages can be in
+any order, as they are in a name=value form anyway and the name
+indicates which parameter is which. Sadly, this was not explicitly
+mentioned in this document, or tested by unit tests. So now we have
+code here and there that assumes that parameters are in a specific
+order anyway, thus losing the benefits of the named parameters. Oh
+well.
+
 client -> server
 ================