[Libreoffice-commits] core.git: sfx2/source

[Michael Weghorn (via logerrit)]

 sfx2/source/view/viewprn.cxx |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit 21fc54777d5dedc33d6bfa23b9f1072a6667eebe
Author:     Michael Weghorn <m.weghorn at posteo.de>
AuthorDate: Fri Apr 3 11:54:42 2020 +0200
Commit:     Michael Weghorn <m.weghorn at posteo.de>
CommitDate: Fri Apr 3 15:22:30 2020 +0200

    tdf#131849 Handle changed doc print options when printer changed
    
    Previously, the SfxPrinterChangeFlags::OPTIONS flag was
    only set for the case that the printer itself was considered
    unchanged ('else' case below).
    
    However, this also needs to be done when the printer is
    considered to have changed, so the flag is properly
    passed in the call to 'SetPrinter' below, to make
    sure that changes in document-specific options are
    properly propagated.
    
    Change-Id: Id91ebbbf40888e52149b40ac25f188af4be425f3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91626
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.weghorn at posteo.de>

diff --git a/sfx2/source/view/viewprn.cxx b/sfx2/source/view/viewprn.cxx
index 9dc713e82007..871ed0104556 100644
--- a/sfx2/source/view/viewprn.cxx
+++ b/sfx2/source/view/viewprn.cxx
@@ -545,6 +545,11 @@ void SfxViewShell::SetPrinter_Impl( VclPtr<SfxPrinter>& pNewPrinter )
     if ( (aTempPrtName != aDocPrtName) || (pDocPrinter->IsDefPrinter() != pNewPrinter->IsDefPrinter()) )
     {
         nChangedFlags |= SfxPrinterChangeFlags::PRINTER|SfxPrinterChangeFlags::JOBSETUP;
+        if ( ! (pNewPrinter->GetOptions() == pDocPrinter->GetOptions()) )
+        {
+            nChangedFlags |= SfxPrinterChangeFlags::OPTIONS;
+        }
+
         pDocPrinter = pNewPrinter;
     }
     else