[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/animations/CustomAnimationPane.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fd95dfdbe28d033596d65c517e12ee91e49c8a7c
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Apr 5 20:33:31 2020 +0100
Commit:     Michael Stahl <michael.stahl at cib.de>
CommitDate: Mon Apr 6 11:28:04 2020 +0200

    attempt to deref end() iterator
    
    seen when dragging last animation in animation pane up one position
    
    Change-Id: I2c5163a58bb67fc7982c41546559207977e8b7c5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91714
    Tested-by: Jenkins
    Reviewed-by: Michael Stahl <michael.stahl at cib.de>

diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx b/sd/source/ui/animations/CustomAnimationPane.cxx
index c63e4d0e8712..8a839475f3ec 100644
--- a/sd/source/ui/animations/CustomAnimationPane.cxx
+++ b/sd/source/ui/animations/CustomAnimationPane.cxx
@@ -2457,7 +2457,7 @@ void CustomAnimationPane::onDragNDropComplete(std::vector< CustomAnimationEffect
             mpMainSequence->moveToBeforeEffect( pEffect, pEffectInsertBefore );
 
             // Done moving effect and its hidden sub-effects when *next* effect is visible.
-            if ( mpCustomAnimationList->isVisible( *aIter ) )
+            if (aIter != aEnd && mpCustomAnimationList->isVisible(*aIter))
                 break;
         }