[Libreoffice-commits] core.git: sc/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Mon Apr 6 14:44:38 UTC 2020


 sc/source/filter/excel/xiescher.cxx |    1 -
 sc/source/filter/xml/xmlcelli.cxx   |    3 +--
 sc/source/ui/view/gridwin.cxx       |    1 -
 3 files changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 9459c2738fd1c2e0a683cb7e314e8ee648b4ca06
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Apr 6 15:47:32 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Apr 6 16:43:53 2020 +0200

    loplugin:unusedvariableplus in sc
    
    Change-Id: I163b0cd5a8dc381322b0113aca23faae29b1b859
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91755
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/filter/excel/xiescher.cxx b/sc/source/filter/excel/xiescher.cxx
index 261a3052007a..6d2416557f59 100644
--- a/sc/source/filter/excel/xiescher.cxx
+++ b/sc/source/filter/excel/xiescher.cxx
@@ -1887,7 +1887,6 @@ void XclImpControlHelper::ApplySheetLinkProps() const
     Reference< XControlModel > xCtrlModel = XclControlHelper::GetControlModel( mxShape );
     if( !xCtrlModel.is() )
         return;
-    ScfPropertySet aPropSet( xCtrlModel );
 
    // sheet links
     if( SfxObjectShell* pDocShell = mrRoot.GetDocShell() )
diff --git a/sc/source/filter/xml/xmlcelli.cxx b/sc/source/filter/xml/xmlcelli.cxx
index b22fb78865dc..a35bd047893f 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -1345,8 +1345,7 @@ void ScXMLTableRowCellContext::PutFormulaCell( const ScAddress& rCellPos )
 
     OUString aText = maFormula->first;
 
-    std::unique_ptr<ScExternalRefManager::ApiGuard> pExtRefGuard (
-            new ScExternalRefManager::ApiGuard(pDoc));
+    ScExternalRefManager::ApiGuard aExtRefGuard(pDoc);
 
     if ( !aText.isEmpty() )
     {
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index ffcdf1656b15..0decc50c00c3 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -3867,7 +3867,6 @@ static SotClipboardFormatId lcl_GetDropFormatId( const uno::Reference<datatransf
         if( aDataHelper.GetTransferableObjectDescriptor( SotClipboardFormatId::OBJECTDESCRIPTOR, aObjDesc ) &&
             aDataHelper.GetSotStorageStream( SotClipboardFormatId::EMBED_SOURCE, xStm ) )
         {
-            tools::SvRef<SotStorage> xStore( new SotStorage( *xStm ) );
             bDoRtf = ( ( aObjDesc.maClassName == SvGlobalName( SO3_SW_CLASSID ) ||
                          aObjDesc.maClassName == SvGlobalName( SO3_SWWEB_CLASSID ) )
                        && ( aDataHelper.HasFormat( SotClipboardFormatId::RTF ) || aDataHelper.HasFormat( SotClipboardFormatId::RICHTEXT ) ) );


More information about the Libreoffice-commits mailing list