[Libreoffice-commits] core.git: xmloff/source
Noel Grandin (via logerrit)
logerrit at kemper.freedesktop.org
Mon Apr 6 19:42:40 UTC 2020
xmloff/source/draw/XMLReplacementImageContext.cxx | 2 --
xmloff/source/draw/animimp.cxx | 2 --
xmloff/source/draw/shapeexport.cxx | 2 +-
xmloff/source/style/impastpl.cxx | 1 -
xmloff/source/text/XMLTextFrameContext.cxx | 3 ---
5 files changed, 1 insertion(+), 9 deletions(-)
New commits:
commit d21e8a437725304a284c749fb4a3a67fa358b891
Author: Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Apr 6 19:06:15 2020 +0200
Commit: Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Apr 6 21:42:04 2020 +0200
loplugin:unusedvariableplus in xmloff
Change-Id: I4acc297acb4327249a452a0318964b75e02d38de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91766
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/xmloff/source/draw/XMLReplacementImageContext.cxx b/xmloff/source/draw/XMLReplacementImageContext.cxx
index 1f9f077fbddf..31ff35fb697d 100644
--- a/xmloff/source/draw/XMLReplacementImageContext.cxx
+++ b/xmloff/source/draw/XMLReplacementImageContext.cxx
@@ -73,8 +73,6 @@ void XMLReplacementImageContext::EndElement()
{
OSL_ENSURE( !m_sHRef.isEmpty() || m_xBase64Stream.is(),
"neither URL nor base64 image data given" );
- rtl::Reference < XMLTextImportHelper > xTxtImport =
- GetImport().GetTextImport();
uno::Reference<graphic::XGraphic> xGraphic;
try
diff --git a/xmloff/source/draw/animimp.cxx b/xmloff/source/draw/animimp.cxx
index 580491ae3eb2..3e7a2eeed8c4 100644
--- a/xmloff/source/draw/animimp.cxx
+++ b/xmloff/source/draw/animimp.cxx
@@ -504,8 +504,6 @@ void XMLAnimationsEffectContext::endFastElement(sal_Int32 )
try
{
- rtl::Reference< XMLShapeImportHelper > xShapeImport( GetImport().GetShapeImport() );
-
if( !maShapeId.isEmpty() )
{
Reference< XPropertySet > xSet;
diff --git a/xmloff/source/draw/shapeexport.cxx b/xmloff/source/draw/shapeexport.cxx
index 41f9595f9716..370bfcf3e44f 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -3307,7 +3307,7 @@ void XMLShapeExport::ImpExportMediaShape(
mrExport.AddAttribute( XML_NAMESPACE_DRAW, XML_MIME_TYPE, sMimeType );
// write plugin
- auto pPluginOBJ = std::make_unique<SvXMLElementExport>(mrExport, XML_NAMESPACE_DRAW, XML_PLUGIN, !( nFeatures & XMLShapeExportFlags::NO_WS ), true);
+ SvXMLElementExport aPluginOBJ(mrExport, XML_NAMESPACE_DRAW, XML_PLUGIN, !( nFeatures & XMLShapeExportFlags::NO_WS ), true);
// export parameters
const OUString aFalseStr( "false" ), aTrueStr( "true" );
diff --git a/xmloff/source/style/impastpl.cxx b/xmloff/source/style/impastpl.cxx
index 29033f3cecec..c347304bc79c 100644
--- a/xmloff/source/style/impastpl.cxx
+++ b/xmloff/source/style/impastpl.cxx
@@ -461,7 +461,6 @@ bool SvXMLAutoStylePoolP_Impl::Add(
XMLAutoStyleFamily &rFamily = **iter;
- std::unique_ptr<XMLAutoStylePoolParent> pTmp(new XMLAutoStylePoolParent(rParentName));
auto itPair = rFamily.m_ParentSet.insert(std::make_unique<XMLAutoStylePoolParent>(
rParentName));
XMLAutoStylePoolParent& rParent = **itPair.first;
diff --git a/xmloff/source/text/XMLTextFrameContext.cxx b/xmloff/source/text/XMLTextFrameContext.cxx
index d8580c3ddb26..5efc4c0a085f 100644
--- a/xmloff/source/text/XMLTextFrameContext.cxx
+++ b/xmloff/source/text/XMLTextFrameContext.cxx
@@ -671,8 +671,6 @@ void XMLTextFrameContext_Impl::Create()
// URL
OSL_ENSURE( !sHRef.isEmpty() || xBase64Stream.is(),
"neither URL nor base64 image data given" );
- rtl::Reference < XMLTextImportHelper > xTxtImport =
- GetImport().GetTextImport();
uno::Reference<graphic::XGraphic> xGraphic;
if (!sHRef.isEmpty())
{
@@ -1269,7 +1267,6 @@ void XMLTextFrameContext_Impl::SetHyperlink( const OUString& rHRef,
if( !xPropSet.is() )
return;
- rtl::Reference< XMLTextImportHelper > xTxtImp = GetImport().GetTextImport();
Reference < XPropertySetInfo > xPropSetInfo =
xPropSet->getPropertySetInfo();
if( !xPropSetInfo.is() ||
More information about the Libreoffice-commits
mailing list