[Libreoffice-commits] core.git: chart2/qa chart2/source

[Noel Grandin (via logerrit)]

 chart2/qa/extras/charttest.hxx              |    1 -
 chart2/source/tools/ObjectIdentifier.cxx    |    6 ++----
 chart2/source/view/axes/VPolarAngleAxis.cxx |    3 ---
 3 files changed, 2 insertions(+), 8 deletions(-)

New commits:
commit 5366cadd6cda9b3c7b4b549a0c9b8c895ea47843
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Apr 6 21:45:37 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Apr 7 08:31:20 2020 +0200

    loplugin:unusedvariableplus in chart2
    
    Change-Id: I8bb958718f71b52819755f3af6d5fcff4af1f596
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91782
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx
index db9a4ed63465..60a526be0b8a 100644
--- a/chart2/qa/extras/charttest.hxx
+++ b/chart2/qa/extras/charttest.hxx
@@ -379,7 +379,6 @@ uno::Sequence < OUString > getWriterChartColumnDescriptions( Reference< lang::XC
     xChartDoc.set( xPropertySet->getPropertyValue( "Model" ), uno::UNO_QUERY );
     CPPUNIT_ASSERT( xChartDoc.is() );
     CPPUNIT_ASSERT( xChartDoc->getDataProvider().is() );
-    uno::Reference<beans::XPropertySet> xProp(xChartDoc->getDataProvider(), uno::UNO_QUERY );
     uno::Reference< chart2::XAnyDescriptionAccess > xAnyDescriptionAccess ( xChartDoc->getDataProvider(), uno::UNO_QUERY_THROW );
     uno::Sequence< OUString > seriesList = xAnyDescriptionAccess->getColumnDescriptions();
     return seriesList;
diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx
index 3c2c45a19e74..c0fc94ec1326 100644
--- a/chart2/source/tools/ObjectIdentifier.cxx
+++ b/chart2/source/tools/ObjectIdentifier.cxx
@@ -621,11 +621,10 @@ OUString ObjectIdentifier::createParticleForSeries(
     return aRet.makeStringAndClear();
 }
 
-OUString ObjectIdentifier::createParticleForLegend( ChartModel& rModel )
+OUString ObjectIdentifier::createParticleForLegend( ChartModel&  )
 {
     OUStringBuffer aRet;
 
-    Reference< XDiagram > xDiagram( rModel.getFirstDiagram() );
     //todo: if more than one diagram is implemented, find the correct diagram which is owner of the given legend
 
     aRet.append( ObjectIdentifier::createParticleForDiagram() );
@@ -637,11 +636,10 @@ OUString ObjectIdentifier::createParticleForLegend( ChartModel& rModel )
 }
 
 OUString ObjectIdentifier::createParticleForLegend(
-        const Reference< frame::XModel >& xChartModel )
+        const Reference< frame::XModel >& )
 {
     OUStringBuffer aRet;
 
-    Reference< XDiagram > xDiagram( ChartModelHelper::findDiagram( xChartModel ) );
     //todo: if more than one diagram is implemented, find the correct diagram which is owner of the given legend
 
     aRet.append( ObjectIdentifier::createParticleForDiagram() );
diff --git a/chart2/source/view/axes/VPolarAngleAxis.cxx b/chart2/source/view/axes/VPolarAngleAxis.cxx
index 2c171d8bb11d..cc2427a87581 100644
--- a/chart2/source/view/axes/VPolarAngleAxis.cxx
+++ b/chart2/source/view/axes/VPolarAngleAxis.cxx
@@ -162,9 +162,6 @@ void VPolarAngleAxis::createLabels()
 
     if( m_aAxisProperties.m_bDisplayLabels )
     {
-        //get the transformed screen values for all tickmarks in aAllTickInfos
-        std::unique_ptr< TickFactory > apTickFactory( createTickFactory() );
-
         //create tick mark text shapes
         //@todo: iterate through all tick depth which should be labeled