[Libreoffice-commits] core.git: reportdesign/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Tue Apr 7 08:04:02 UTC 2020


 reportdesign/source/filter/xml/xmlfilter.cxx    |    2 --
 reportdesign/source/ui/report/ReportSection.cxx |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 97ac4de1e3a41a346e19aa3ca3a4e05594073ae7
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Apr 7 08:49:44 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Apr 7 10:03:19 2020 +0200

    loplugin:unusedvariableplus in reportdesign
    
    Change-Id: Ie8568f524a1f804e07890ee7828a81f1752fcfd0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91793
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/reportdesign/source/filter/xml/xmlfilter.cxx b/reportdesign/source/filter/xml/xmlfilter.cxx
index 8f493a9c8532..ddd4a6a28dad 100644
--- a/reportdesign/source/filter/xml/xmlfilter.cxx
+++ b/reportdesign/source/filter/xml/xmlfilter.cxx
@@ -423,8 +423,6 @@ bool ORptFilter::implImport( const Sequence< PropertyValue >& rDescriptor )
 
     if ( !sFileName.isEmpty() )
     {
-        uno::Reference<XComponent> xCom = GetModel();
-
         tools::SvRef<SfxMedium> pMedium = new SfxMedium(
                 sFileName, ( StreamMode::READ | StreamMode::NOCREATE ) );
 
diff --git a/reportdesign/source/ui/report/ReportSection.cxx b/reportdesign/source/ui/report/ReportSection.cxx
index 689f0a0c67f3..7482b51925b7 100644
--- a/reportdesign/source/ui/report/ReportSection.cxx
+++ b/reportdesign/source/ui/report/ReportSection.cxx
@@ -126,9 +126,9 @@ void OReportSection::dispose()
     m_pFunc.reset();
 
     {
-        ::std::unique_ptr<OSectionView> aTemp( m_pView);
         if ( m_pView )
             m_pView->EndListening( *m_pModel );
+        delete m_pView;
         m_pView = nullptr;
     }
     m_pParent.clear();


More information about the Libreoffice-commits mailing list