[Libreoffice-commits] online.git: loleaflet/css loleaflet/src

Pedro Pinto Silva (via logerrit) logerrit at kemper.freedesktop.org
Tue Apr 7 09:47:12 UTC 2020


 loleaflet/css/mobilewizard.css                   |    2 +-
 loleaflet/src/control/Control.JSDialogBuilder.js |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 63744d641bdab2486afef9e763c90e8d698339ec
Author:     Pedro Pinto Silva <pedro.silva at collabora.com>
AuthorDate: Tue Apr 7 11:13:17 2020 +0200
Commit:     Pedro Pinto da Silva <pedro.silva at collabora.com>
CommitDate: Tue Apr 7 11:46:54 2020 +0200

    Mobile: mWizard: make sure every row item with a checkbox is properly aligned by
    
    - Add class
    - make sure there is no float position affecting those
    (previously that ^css rule was applied to all elements that have in their id the prefix checkbutton via "div[id^=checkbutton]" but not all elements were being set with that convention in mind)
    
    Change-Id: I285955d956a60002065421c4e8384df6359c4d68
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91806
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Tested-by: Pedro Pinto da Silva <pedro.silva at collabora.com>
    Reviewed-by: Pedro Pinto da Silva <pedro.silva at collabora.com>

diff --git a/loleaflet/css/mobilewizard.css b/loleaflet/css/mobilewizard.css
index 95f3cc133..4bc42c09b 100644
--- a/loleaflet/css/mobilewizard.css
+++ b/loleaflet/css/mobilewizard.css
@@ -713,7 +713,7 @@ div#mobile-wizard-content .spinfield:active .spinfieldimage, div#mobile-wizard-c
 #top{background: url(images/sc_aligntop.svg) no-repeat center;}
 #bottom{background: url(images/sc_alignbottom.svg) no-repeat center;}
 #standard{background: url(images/sc_alignverticalcenter.svg) no-repeat center;}
-div[id^=checkbutton]{
+.checkbutton{
 	clear: both;
 }
 #mobile-wizard input[type=checkbox]:disabled{
diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js b/loleaflet/src/control/Control.JSDialogBuilder.js
index 6763cd9e3..8727e065c 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -561,6 +561,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
 
 	_checkboxControl: function(parentContainer, data, builder) {
 		var div = L.DomUtil.createWithId('div', data.id, parentContainer);
+		L.DomUtil.addClass(div, 'checkbutton');
 
 		var checkboxLabel = L.DomUtil.create('label', '', div);
 		checkboxLabel.innerHTML = builder._cleanText(data.text);


More information about the Libreoffice-commits mailing list