[Libreoffice-commits] online.git: cypress_test/integration_tests

Tamás Zolnai (via logerrit) logerrit at kemper.freedesktop.org
Thu Apr 16 13:18:36 UTC 2020


 cypress_test/integration_tests/mobile/calc/number_format_spec.js |   20 ++++------
 1 file changed, 8 insertions(+), 12 deletions(-)

New commits:
commit bd88fb0cd2ea1bafd0061631c9dac42a1d7fd8c3
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Thu Apr 16 14:17:20 2020 +0200
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Thu Apr 16 15:18:09 2020 +0200

    cypress: mobile: some issues were fixed on number formatting page.
    
    So enable the related checks.
    
    Change-Id: Id8af54e8a47de96a9147f074570e0c2b35205e3d
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92361
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/cypress_test/integration_tests/mobile/calc/number_format_spec.js b/cypress_test/integration_tests/mobile/calc/number_format_spec.js
index 20d7ecebe..8eaccc47d 100644
--- a/cypress_test/integration_tests/mobile/calc/number_format_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/number_format_spec.js
@@ -81,9 +81,8 @@ describe('Apply number formatting.', function() {
 		cy.get('#NumberFormatPercentimg')
 			.should('have.class', 'selected');
 
-		// TODO: combobox entry is not updated
-		//cy.get('#numberformatcombobox .ui-header-left')
-		//	.should('have.text', 'Percent');
+		cy.get('#numberformatcombobox .ui-header-left')
+			.should('have.text', 'Percent');
 
 		// Decimal and leading zeros are changed.
 		cy.get('#decimalplaces input')
@@ -139,9 +138,8 @@ describe('Apply number formatting.', function() {
 		cy.get('#NumberFormatCurrencyimg')
 			.should('have.class', 'selected');
 
-		// TODO: combobox entry is not updated
-		//cy.get('#numberformatcombobox .ui-header-left')
-		//	.should('have.text', 'Currency');
+		cy.get('#numberformatcombobox .ui-header-left')
+			.should('have.text', 'Currency');
 
 		// Decimal and leading zeros are changed.
 		cy.get('#decimalplaces input')
@@ -202,13 +200,11 @@ describe('Apply number formatting.', function() {
 		cy.get('#NumberFormatDecimal')
 			.click();
 
-		// TODO: this state is missing here
-		//cy.get('#NumberFormatDecimalimg')
-		//	.should('have.class', 'selected');
+		cy.get('#NumberFormatDecimalimg')
+			.should('have.class', 'selected');
 
-		// TODO: combobox entry is not updated
-		//cy.get('#numberformatcombobox .ui-header-left')
-		//	.should('have.text', 'Number');
+		cy.get('#numberformatcombobox .ui-header-left')
+			.should('have.text', 'Number');
 
 		calcHelper.copyContentToClipboard();
 


More information about the Libreoffice-commits mailing list