[Libreoffice-commits] core.git: sc/source

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Thu Apr 16 16:03:38 UTC 2020


 sc/source/ui/view/dbfunc3.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f8fa661cad23c8c5c251ee3391de90d40e7d8a4d
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Thu Apr 16 16:09:54 2020 +0200
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Thu Apr 16 18:03:02 2020 +0200

    cid#1462266: Logically dead code (sc/dbfunc3)
    
    Regression from:
    commit 61d8db6b1a2026a29f61eaa691beb3c6cf05de5c
    Author: Noel Grandin <noel.grandin at collabora.co.uk>
    Date:   Wed Apr 15 09:25:22 2020 +0200
    
        loplugin:buriedassign in sc
    
        Change-Id: I9b4146c4e8814a36c7bfcd4c31f913c8412320e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92244
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    
    Change-Id: I5835f5c92cdf381a57ac6ccf627e327ae9f9e26b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92377
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx
index 8b7782ed2e25..d7faee139d0c 100644
--- a/sc/source/ui/view/dbfunc3.cxx
+++ b/sc/source/ui/view/dbfunc3.cxx
@@ -145,7 +145,7 @@ void ScDBFunc::TestRemoveOutline( bool& rCol, bool& rRow )
             {
                 ScOutlineArray& rArray = pTable->GetColArray();
                 ScSubOutlineIterator aColIter( &rArray );
-                while (bColFound)
+                while (!bColFound)
                 {
                     pEntry=aColIter.GetNext();
                     if (!pEntry)


More information about the Libreoffice-commits mailing list