[Libreoffice-commits] online.git: net/Socket.hpp net/SslSocket.hpp

[Tor Lillqvist (via logerrit)]

 net/Socket.hpp    |    4 ++--
 net/SslSocket.hpp |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit e835bbf413dce4c1ea3c8a6f3257881fbbe91409
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Sun Apr 19 22:44:12 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Sun Apr 19 22:05:29 2020 +0200

    YAGNI: Bin bool parameter that is passed as true at the one single call site
    
    Change-Id: I13b0ff612f8ca0970b3ab7fac3e92761c3c332d4
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92509
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/net/Socket.hpp b/net/Socket.hpp
index 5155a7bc8..bc44f208b 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -1106,9 +1106,9 @@ protected:
 
     void dumpState(std::ostream& os) override;
 
-    void setShutdownSignalled(bool shutdownSignalled)
+    void setShutdownSignalled()
     {
-        _shutdownSignalled = shutdownSignalled;
+        _shutdownSignalled = true;
     }
 
     bool isShutdownSignalled() const
diff --git a/net/SslSocket.hpp b/net/SslSocket.hpp
index 4d5745485..508cecece 100644
--- a/net/SslSocket.hpp
+++ b/net/SslSocket.hpp
@@ -63,7 +63,7 @@ public:
 
         if (!isShutdownSignalled())
         {
-            setShutdownSignalled(true);
+            setShutdownSignalled();
             SslStreamSocket::closeConnection();
         }