[Libreoffice-commits] core.git: Changes to 'distro/cib/libreoffice-6-3'

Wed Apr 22 00:28:01 UTC 2020

New branch 'distro/cib/libreoffice-6-3' available with the following commits:
commit 2991e365d54d8c60cac4583d6e0970902ae2c87d
Author: Mike Kaganski <mike.kaganski at collabora.com>
Date:   Thu Jan 2 15:30:36 2020 +0300

    Delete google_breakpad::ExceptionHandler before calling _exit()
    
    While debugging tdf#129712 on Windows, I saw this sequence:
    
    1. nullptr was dereferenced (the reason for tdf#129712).
    2. ExceptionHandler::HandleException was called (in
       workdir/UnpackedTarball/breakpad/src/client/windows/handler/exception_handler.cc).
    3. It called ExceptionHandler::WriteMinidumpOnHandlerThread.
    4. Minidump was created in ExceptionHandler::ExceptionHandlerThreadMain.
    5. Document Recovery dialog was shown in Desktop::Exception (in
       desktop/source/app/app.cxx).
    6. After closing dialog, _exit() was called in Desktop::Exception.
    7. All threads except main were terminated.
    8. Another access violation was thrown in the "minimal CRT cleanup".
    9. ExceptionHandler::HandleException called again.
    10. ExceptionHandler::WriteMinidumpOnHandlerThread hung on WaitForSingleObject
        because handler thread that should release the semaphore was terminated
        already at step 7.
    
    The process had to be killed manually.
    
    This change destroys the breakpad handler at the start of Desktop::Exception,
    which de-registers itself (on Windows it uses SetUnhandledExceptionFilter).
    Other than preventing the hang, the rationale also is that keeping the handler
    after first minidump creation is wrong: even if the second minidump creation
    succeeded, uploading it to crashdump server would give not the actual problem,
    but some unrelated stack.
    
    Change-Id: If12d0c7db519693f733b5ab3b8a288cef800a149
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86104
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Tested-by: Mike Kaganski <mike.kaganski at collabora.com>
    (cherry picked from commit 12b5892cf9c78dd917f2e50672cd250478e6c7d6)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89690
    Tested-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

commit 74c1af5de8a5c06e8c860898f6f406b881ebf7e3
Author: Thorsten Behrens <Thorsten.Behrens at CIB.de>
Date:   Tue Apr 21 17:19:29 2020 +0200

    Remove collect usage info from GUI
    
    Change-Id: I1a7420c557187097b424d298c020bcb837a8261c

commit f36fc71398ed592f1a0105f9aab951917a192ceb
Author: Thorsten Behrens <Thorsten.Behrens at CIB.de>
Date:   Tue Apr 21 01:13:46 2020 +0200

    related tdf#127711: read crashdump URL from ini file
    
    Change-Id: I68f06aaf5b8c053d1deef2021876b1399e422dd7

commit e5506fe276cc256e7b4131e09c04bd9c3118ca81
Author: Juergen Funk <juergen.funk_ml at cib.de>
Date:   Mon Nov 4 10:42:06 2019 +0100

    tdf#127711 - A runtime-switch for the MiniCrashDump and associated changes
    
    - add CrashDumpEnable to soffice.ini
    - also check env var CRASH_DUMP_ENABLE (overrides soffice.ini)
    - make sure _all_ binaries are added to symstore
    
    This is a squash of:
     https://gerrit.libreoffice.org/79273
     https://gerrit.libreoffice.org/81989
     https://gerrit.libreoffice.org/c/core/+/87260
     https://gerrit.libreoffice.org/c/core/+/87261
     https://gerrit.libreoffice.org/79272
     https://gerrit.libreoffice.org/83171
     https://gerrit.libreoffice.org/82751
     https://gerrit.libreoffice.org/83066
     https://gerrit.libreoffice.org/83726
     https://gerrit.libreoffice.org/c/core/+/86465

commit ae1e7a874809d1eea761cd5badea46b4a6e92ed2
Author: Thorsten Behrens <thorsten.behrens at cib.de>
Date:   Tue Jun 11 01:24:26 2019 +0200

    Some product-name-with-spaces fixes
    
    - use productname var w/o space for config dir
      ..which also saves some duplicated code
    - add hack to make rpmbuild get a proper build root
      -> otherwise rpm BUILDROOT will contain spaces, and things break
         at various places during packaging
    
    Change-Id: I20229ce533913fa000978aa84b1a2a5d998da14d

commit 5c897e3eeaec2807c9df7a71536e5a699cd79be5
Author: Marina Latini (CIB) <Marina.Latini at cib.de>
Date:   Thu May 9 22:07:10 2019 +0200

    Add final CIB branding and product name update
    
    - new brand folder and icon set
    - new icon set available in configure.ac and new CIB color for the
      startcenter
    - new LibreOffice powered by CIB product with SDK
    - new flat logo and main svg app
    - new Banner.bmp and Image.bmp for windows installer
    - new branding for MSI and splash screen
    - new branded locolor and hicolor icons
    
    Change-Id: Id583453910f50839dbe1f114afc5c6a4aa6c2e07

commit c86f3179e93e0ce09333b2fb6c65a73734424457
Author: Thorsten Behrens <Thorsten.Behrens at CIB.de>
Date:   Mon Jun 17 02:41:36 2019 +0200

    Remove Help menu donate entry for LTS version
    
    Change-Id: I78db5b1989dee9ab10d670f26d08237335ffcc29

commit e0fc6bab489f549d9a299b8b16294d2044df91b6
Author: Thorsten Behrens <Thorsten.Behrens at CIB.de>
Date:   Wed Jul 18 18:06:44 2018 +0200

    Default OpenGL to off on all platforms
    
    Change-Id: Ide04d3b37b9fabb64d514fd87acbdfe9e49e6727

commit 9d93c34249893cebea9c13458cbae7e34a48c6a8
Author: Katarina Behrens <Katarina.Behrens at cib.de>
Date:   Tue Feb 9 10:38:29 2016 +0100

    Point to CIB helpdesk
    
    Conflicts:
    	sfx2/source/appl/appserv.cxx
    
    Change-Id: Ifbbb9e9d2bbee40998c07d1c68b61cd20d77dbc3