[Libreoffice-commits] online.git: kit/Kit.cpp

[Dennis Francis (via logerrit)]

 kit/Kit.cpp |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 217dd2de5458cb91c6b9dffeb7db84e9cde88c0c
Author:     Dennis Francis <dennis.francis at collabora.com>
AuthorDate: Tue Apr 21 14:40:30 2020 +0530
Commit:     Michael Meeks <michael.meeks at collabora.com>
CommitDate: Wed Apr 22 09:48:55 2020 +0200

    Do not broadcast view-cursor invalidation messages
    
    in kit as these are sent by core to specific view(s) by ultimately calling either
    (as seen from the usages of LOK_CALLBACK_INVALIDATE_VIEW_CURSOR in core)
    
    1. SfxLokHelper::notifyOtherView() where it sends to particular view.
    
    or
    
    2. SfxLokHelper::notifyOtherViews() where it sends to all views except
    the current view.
    
    The core makes the decision to broadcast or not, and if it does, then
    the kit's broadcast of broadcasted messages can only cause a blowup of messaging
    complexiity w.r.t number of views. It also does not make sense to send
    view-cursor messages meant for a view to be sent to others in Calc
    with clients of hetrogeneous zooms.
    
    Change-Id: Ib07c5fbba9bb05c59048561d2c26aed00f3be598
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92633
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index a34b91334..3801af4bd 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1322,8 +1322,7 @@ public:
             // all views have to be in sync
             tileQueue->put("callback all " + std::to_string(type) + ' ' + payload);
         }
-        else if (type == LOK_CALLBACK_INVALIDATE_VIEW_CURSOR ||
-                 type == LOK_CALLBACK_CELL_VIEW_CURSOR)
+        else if (type == LOK_CALLBACK_CELL_VIEW_CURSOR)
         {
             // these should go to all views but the one that that triggered it
             tileQueue->put("callback except-" + targetViewId + ' ' + std::to_string(type) + ' ' + payload);