[Libreoffice-commits] online.git: kit/Kit.cpp

[Dennis Francis (via logerrit)]

 kit/Kit.cpp |    5 -----
 1 file changed, 5 deletions(-)

New commits:
commit 986bcce1c961df09169ff87dd22c1f84e4be036c
Author:     Dennis Francis <dennis.francis at collabora.com>
AuthorDate: Sun Apr 26 08:08:58 2020 +0530
Commit:     Dennis Francis <dennis.francis at collabora.com>
CommitDate: Tue Apr 28 13:30:22 2020 +0200

    kit: Do not broadcast cell-cursor invalidation messages
    
    is a follow up of 217dd2de5458cb91c6b9dffeb7db84e9cde88c0c
    "Do not broadcast view-cursor invalidation messages"
    
    But this change is implicitly Calc specific because
    LOK_CALLBACK_CELL_VIEW_CURSOR is used only in Calc.
    
    This patch fixes the following bug:
    
    Suppose there are at least three clients each with a different zoom and the
    all client's cursors are placed in same tab-view and away from A1. Now
    it can be seen at once that the cursors of other clients in each client
    are rendered incorrectly.
    
    The commit c6b18508aec0e609b4c3c000faf89c21e93620bd in core.git
    "lok: send other views our cursor position in their view co-ordinates"
    does the right thing by sending view specific cell-cursor positions.
    But the broadcast of these messages in Kit.cpp means every client will
    get the messages intended for others and possibly end up using the
    wrong messages to draw the cell-cursors.
    
    Change-Id: I6e9534c2e562f34b5c1fe37242b36e076b9319c8
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92916
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Dennis Francis <dennis.francis at collabora.com>

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 46eaf55c9..ae775fee3 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1388,11 +1388,6 @@ public:
             // all views have to be in sync
             tileQueue->put("callback all " + std::to_string(type) + ' ' + payload);
         }
-        else if (type == LOK_CALLBACK_CELL_VIEW_CURSOR)
-        {
-            // these should go to all views but the one that that triggered it
-            tileQueue->put("callback except-" + targetViewId + ' ' + std::to_string(type) + ' ' + payload);
-        }
         else
             tileQueue->put("callback " + std::to_string(descriptor->getViewId()) + ' ' + std::to_string(type) + ' ' + payload);