[Libreoffice-commits] core.git: sc/qa

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Sun Aug 2 09:36:09 UTC 2020


 sc/qa/unit/data/ods/tdf119533.ods      |binary
 sc/qa/unit/subsequent_filters-test.cxx |   21 +++++++++++++++++++++
 2 files changed, 21 insertions(+)

New commits:
commit 47ca84c47b03009fc9be751f1090f583bb3f53b7
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Fri Jul 31 20:02:16 2020 +0200
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Sun Aug 2 11:35:35 2020 +0200

    tdf#119533: sc_subsequent_filters_test: Add unittest
    
    Change-Id: I9131c8e2e1b7092f0c5b1dcdd7f9a93568ab8d12
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99895
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sc/qa/unit/data/ods/tdf119533.ods b/sc/qa/unit/data/ods/tdf119533.ods
new file mode 100644
index 000000000000..7886962cdfdc
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf119533.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index 52f304235473..c602ec875beb 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -231,6 +231,7 @@ public:
     void testTdf98844();
     void testTdf100458();
     void testTdf134455();
+    void testTdf119533();
     void testTdf127982();
     void testTdf131424();
     void testTdf100709XLSX();
@@ -393,6 +394,7 @@ public:
     CPPUNIT_TEST(testTdf98844);
     CPPUNIT_TEST(testTdf100458);
     CPPUNIT_TEST(testTdf134455);
+    CPPUNIT_TEST(testTdf119533);
     CPPUNIT_TEST(testTdf127982);
     CPPUNIT_TEST(testTdf131424);
     CPPUNIT_TEST(testTdf100709XLSX);
@@ -3834,6 +3836,25 @@ void ScFiltersTest::testTdf134455()
     xDocSh->DoClose();
 }
 
+void ScFiltersTest::testTdf119533()
+{
+    ScDocShellRef xDocSh = loadDoc("tdf119533.", FORMAT_ODS);
+    CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.is());
+    ScDocument& rDoc = xDocSh->GetDocument();
+
+    // Without fix in place, this test would have failed with
+    // - Expected: 0.5
+    // - Actual  : 0.483333333333333
+    CPPUNIT_ASSERT_EQUAL(OUString("0.5"), rDoc.GetString(ScAddress(4,0,0)));
+
+    // Without fix in place, this test would have failed with
+    // - Expected: 9.5
+    // - Actual  : 9.51666666666667
+    CPPUNIT_ASSERT_EQUAL(OUString("9.5"), rDoc.GetString(ScAddress(5,0,0)));
+
+    xDocSh->DoClose();
+}
+
 void ScFiltersTest::testTdf127982()
 {
     ScDocShellRef xDocSh = loadDoc("tdf127982.", FORMAT_ODS);


More information about the Libreoffice-commits mailing list