[Libreoffice-commits] online.git: loleaflet/src

Dennis Francis (via logerrit) logerrit at kemper.freedesktop.org
Mon Aug 3 07:31:34 UTC 2020


 loleaflet/src/layer/vector/Path.js |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit af0ec0d11e3bb8fadefe977094cf35baa05fb874
Author:     Dennis Francis <dennis.francis at collabora.com>
AuthorDate: Mon Aug 3 11:31:53 2020 +0530
Commit:     Dennis Francis <dennis.francis at collabora.com>
CommitDate: Mon Aug 3 09:31:14 2020 +0200

    do not remove references to node object(s) in L.Path...
    
    when removing the Path object from the renderer via
    Map.removeLayer() -> Path.onRemove()
    
    This is because, some L.Path specializations like L.PathTransform.Handle
    expects that its node objects are retained even after removing itself
    from the Map/renderer. (Possibly there are more specializations where
    this is expected).
    
    Note: The removal of node object(s) was introduced as part of
    a59076e1ca88a6f2c8c67ce45bf769e963cf0717
    
    Change-Id: I398a6035271da725852cf29104438b47c516c187
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99981
    Tested-by: Jenkins
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Dennis Francis <dennis.francis at collabora.com>

diff --git a/loleaflet/src/layer/vector/Path.js b/loleaflet/src/layer/vector/Path.js
index 1c06e53ef..17b777354 100644
--- a/loleaflet/src/layer/vector/Path.js
+++ b/loleaflet/src/layer/vector/Path.js
@@ -35,7 +35,6 @@ L.Path = L.Layer.extend({
 
 	onRemove: function () {
 		this._renderer._removePath(this);
-		this._pathNodeCollection.clear();
 	},
 
 	getEvents: function () {


More information about the Libreoffice-commits mailing list