[Libreoffice-commits] core.git: desktop/source include/sfx2

[Mert Tumer (via logerrit)]

 desktop/source/lib/init.cxx                |   20 ++++++++++++++++----
 include/sfx2/sidebar/SidebarController.hxx |    1 +
 2 files changed, 17 insertions(+), 4 deletions(-)

New commits:
commit ff23d87cb00388095a94b90e061564fc179e1823
Author:     Mert Tumer <mert.tumer at collabora.com>
AuthorDate: Fri May 8 17:23:12 2020 +0300
Commit:     Mert Tumer <mert.tumer at collabora.com>
CommitDate: Tue Aug 4 12:44:31 2020 +0200

    mobile: fix calc chart wizard properties is not shown
    
    Change-Id: I2fd98ddbdb529c3f224299c6824b4743797925be
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93747
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Andras Timar <andras.timar at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97061
    Reviewed-by: Jan Holesovsky <kendy at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98248
    Tested-by: Jenkins
    Reviewed-by: Mert Tumer <mert.tumer at collabora.com>

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 346c5174accd..db6dc07262a0 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -907,10 +907,24 @@ void setupSidebar(bool bShow, const OUString& sidebarDeckId = "")
         if (!pDockingWin)
             return;
 
+        OUString currentDeckId = pDockingWin->GetSidebarController()->GetCurrentDeckId();
+
+        // check if it is the chart deck id, if it is, don't switch to default deck
+        bool switchToDefault = true;
+
+        if (currentDeckId == "ChartDeck")
+            switchToDefault = false;
+
         if (!sidebarDeckId.isEmpty())
         {
             pDockingWin->GetSidebarController()->SwitchToDeck(sidebarDeckId);
         }
+        else
+        {
+            if (switchToDefault)
+                pDockingWin->GetSidebarController()->SwitchToDefaultDeck();
+        }
+
         pDockingWin->SyncUpdate();
     }
     else
@@ -3750,7 +3764,6 @@ static void doc_postUnoCommand(LibreOfficeKitDocument* pThis, const char* pComma
     SfxObjectShell* pDocSh = SfxObjectShell::Current();
     OUString aCommand(pCommand, strlen(pCommand), RTL_TEXTENCODING_UTF8);
     LibLODocument_Impl* pDocument = static_cast<LibLODocument_Impl*>(pThis);
-    OUString sidebarDeckId = "PropertyDeck";
 
     std::vector<beans::PropertyValue> aPropertyValuesVector(jsonToPropertyValuesVector(pArguments));
 
@@ -3906,13 +3919,12 @@ static void doc_postUnoCommand(LibreOfficeKitDocument* pThis, const char* pComma
     }
     else if (gImpl && aCommand == ".uno:LOKSidebarWriterPage")
     {
-        sidebarDeckId = "WriterPageDeck";
-        setupSidebar(true, sidebarDeckId);
+        setupSidebar(true, "WriterPageDeck");
         return;
     }
     else if (gImpl && aCommand == ".uno:SidebarShow")
     {
-        setupSidebar(true, sidebarDeckId);
+        setupSidebar(true);
         return;
     }
     else if (gImpl && aCommand == ".uno:SidebarHide")
diff --git a/include/sfx2/sidebar/SidebarController.hxx b/include/sfx2/sidebar/SidebarController.hxx
index d03576b3416d..e9b653762e82 100644
--- a/include/sfx2/sidebar/SidebarController.hxx
+++ b/include/sfx2/sidebar/SidebarController.hxx
@@ -134,6 +134,7 @@ public:
     FocusManager& GetFocusManager() { return maFocusManager;}
 
     ResourceManager* GetResourceManager() { return mpResourceManager.get();}
+    auto& GetCurrentDeckId() const { return msCurrentDeckId; }
 
    // std::unique_ptr<ResourceManager> GetResourceManager() { return mpResourceManager;}