[Libreoffice-commits] core.git: extensions/source
Stephan Bergmann (via logerrit)
logerrit at kemper.freedesktop.org
Fri Aug 7 16:57:32 UTC 2020
extensions/source/logging/csvformatter.cxx | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
New commits:
commit f3da84db230a10551bbdbd6cdf5e4cf669e54e2a
Author: Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Aug 7 14:38:07 2020 +0200
Commit: Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Aug 7 18:56:51 2020 +0200
Make use of std string_view
Change-Id: Ic4b330b7d046ba77e51d32d156501a18e3782985
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100313
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/extensions/source/logging/csvformatter.cxx b/extensions/source/logging/csvformatter.cxx
index 866833c41fd5..9ab747ad504d 100644
--- a/extensions/source/logging/csvformatter.cxx
+++ b/extensions/source/logging/csvformatter.cxx
@@ -30,6 +30,7 @@
#include <rtl/ustrbuf.hxx>
#include <stdio.h>
+#include <string_view>
namespace logging
{
@@ -91,12 +92,7 @@ namespace
bool needsQuoting(const OUString& str)
{
- static const OUString quote_trigger_chars = "\",\n\r";
- sal_Int32 len = str.getLength();
- for(sal_Int32 i=0; i<len; i++)
- if(quote_trigger_chars.indexOf(str[i])!=-1)
- return true;
- return false;
+ return std::u16string_view(str).find_first_of(u"\",\n\r") != std::u16string_view::npos;
};
void appendEncodedString(OUStringBuffer& buf, const OUString& str)
More information about the Libreoffice-commits
mailing list