[Libreoffice-commits] core.git: cppuhelper/source

[Stephan Bergmann (via logerrit)]

 cppuhelper/source/typemanager.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 986bd8b93b35ad7f2760dfe0576860532daa0e42
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Aug 11 20:22:31 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Aug 12 06:08:48 2020 +0200

    -Werror,-Wuninitialized (apparently new in Clang 12 trunk)
    
    > cppuhelper/source/typemanager.cxx:1571:47: error: field 'entity_' is uninitialized when used here [-Werror,-Wuninitialized]
    >         ServiceBasedSingletonDescription_Base(entity_->isPublished()),
    >                                               ^
    
    The code was like that ever since it was introduced in
    fa559f1c416884015d1d83d0a7ac8803e745d9df "WIP: Experimental new binary type.rdb
    format".  Odd that that never caused an issue, but the code appears to at least
    never be executed during `make check`.
    
    Change-Id: I19fe78162c7c4a9211c380648595df9aa54bf4d7
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100554
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/cppuhelper/source/typemanager.cxx b/cppuhelper/source/typemanager.cxx
index c03780b1e932..8949ea4c9547 100644
--- a/cppuhelper/source/typemanager.cxx
+++ b/cppuhelper/source/typemanager.cxx
@@ -1568,7 +1568,7 @@ public:
         rtl::Reference< cppuhelper::TypeManager > const & manager,
         OUString const & name,
         rtl::Reference< unoidl::ServiceBasedSingletonEntity > const & entity):
-        ServiceBasedSingletonDescription_Base(entity_->isPublished()),
+        ServiceBasedSingletonDescription_Base(entity->isPublished()),
         manager_(manager), name_(name), entity_(entity)
     { assert(manager.is()); assert(entity.is()); }