[Libreoffice-commits] core.git: sw/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Fri Aug 14 11:53:38 UTC 2020


 sw/source/uibase/docvw/edtwin.cxx |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 93e55876615bcf6eef3b11a7741cf47caa322101
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Fri Aug 14 10:02:41 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Aug 14 13:52:56 2020 +0200

    improve dodgy code
    
    adding together constants like this is not safe
    
    Change-Id: I6c92b591e623fed9adcf76c08fcd1fb136f8d423
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100724
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sw/source/uibase/docvw/edtwin.cxx b/sw/source/uibase/docvw/edtwin.cxx
index 49d759d89aaa..f35cf8705d21 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -4285,9 +4285,10 @@ void SwEditWin::MouseMove(const MouseEvent& _rMEvt)
                 else
                 {
                     if( !rMEvt.IsSynthetic() &&
-                            !(( MOUSE_LEFT + KEY_MOD1 ==
-                            rMEvt.GetModifier() + rMEvt.GetButtons() ) &&
-                            rSh.Is_FnDragEQBeginDrag() && !rSh.IsAddMode() ))
+                        !( MOUSE_LEFT == rMEvt.GetButtons() &&
+                           KEY_MOD1 == rMEvt.GetModifier() &&
+                           rSh.Is_FnDragEQBeginDrag() &&
+                           !rSh.IsAddMode() ) )
                     {
                         rSh.Drag( &aDocPt, false );
 


More information about the Libreoffice-commits mailing list