[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/stringstatic.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit de9f70675a3c9e02f02c71fd238735b9015634ff
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Aug 19 14:33:06 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Aug 19 16:43:13 2020 +0200

    isStaticLocal should imply hasGlobalStorage
    
    (See documentation of clang::VarDecl::hasGlobalStorage:   "This includes all
    global variables as well as static variables declared within a function.")
    
    Change-Id: I59d9e9e946033b6d4c52e80cfeaf59a9b036b349
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100995
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/compilerplugins/clang/stringstatic.cxx b/compilerplugins/clang/stringstatic.cxx
index 282144042f4e..6f2c38dfc748 100644
--- a/compilerplugins/clang/stringstatic.cxx
+++ b/compilerplugins/clang/stringstatic.cxx
@@ -81,7 +81,7 @@ bool StringStatic::VisitVarDecl(VarDecl const* varDecl)
     if (ignoreLocation(varDecl))
         return true;
     QualType qt = varDecl->getType();
-    if (!varDecl->hasGlobalStorage() && !varDecl->isStaticLocal())
+    if (!varDecl->hasGlobalStorage())
         return true;
     if (!varDecl->isThisDeclarationADefinition()
         || !qt.isConstQualified())