[Libreoffice-commits] core.git: svtools/source sw/qa

Ahmed ElShreif (via logerrit) logerrit at kemper.freedesktop.org
Thu Aug 27 18:33:21 UTC 2020


 svtools/source/uitest/uiobject.cxx      |    2 +-
 sw/qa/uitest/writer_tests2/fontworks.py |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5be3b44a87fafebe56840eadd983020f57e566c4
Author:     Ahmed ElShreif <aelshreif7 at gmail.com>
AuthorDate: Mon Aug 24 11:00:09 2020 +0200
Commit:     Ahmed ElShreif <aelshreif7 at gmail.com>
CommitDate: Thu Aug 27 20:32:35 2020 +0200

    uitest : Change all the ValueSet uitest statments to CHOOSE
    
    instead of using "SELECT" which similar to other UIObjects we will write "CHOOSE"
    
    Change-Id: I32c1ab5f8a5dd21df87d90923d5821f8f0b16e76
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101265
    Tested-by: Jenkins
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/svtools/source/uitest/uiobject.cxx b/svtools/source/uitest/uiobject.cxx
index 904a81be1bb6..db593581d6c2 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -20,7 +20,7 @@ ValueSetUIObject::ValueSetUIObject(const VclPtr<vcl::Window>& xSetWin, ValueSet*
 
 void ValueSetUIObject::execute(const OUString& rAction, const StringMap& rParameters)
 {
-    if (rAction == "SELECT")
+    if (rAction == "CHOOSE")
     {
         if (rParameters.find("POS") != rParameters.end())
         {
diff --git a/sw/qa/uitest/writer_tests2/fontworks.py b/sw/qa/uitest/writer_tests2/fontworks.py
index df72f5ed67a4..d3034dc8134b 100644
--- a/sw/qa/uitest/writer_tests2/fontworks.py
+++ b/sw/qa/uitest/writer_tests2/fontworks.py
@@ -24,13 +24,13 @@ class fontWorksDialog(UITestCase):
 
         FontWorkSelector = xDialog.getChild("ctlFavorites")
         # Select element with id (3)
-        FontWorkSelector.executeAction("SELECT", mkPropertyValues({"POS": "3"}))
+        FontWorkSelector.executeAction("CHOOSE", mkPropertyValues({"POS": "3"}))
         self.assertEqual(get_state_as_dict(FontWorkSelector)["SelectedItemPos"], "2")
         self.assertEqual(get_state_as_dict(FontWorkSelector)["SelectedItemId"], "3")
         self.assertEqual(get_state_as_dict(FontWorkSelector)["ItemsCount"], "36")
 
         # Select element with id (7)
-        FontWorkSelector.executeAction("SELECT", mkPropertyValues({"POS": "7"}))
+        FontWorkSelector.executeAction("CHOOSE", mkPropertyValues({"POS": "7"}))
         self.assertEqual(get_state_as_dict(FontWorkSelector)["SelectedItemPos"], "6")
         self.assertEqual(get_state_as_dict(FontWorkSelector)["SelectedItemId"], "7")
 


More information about the Libreoffice-commits mailing list