[Libreoffice-commits] core.git: desktop/qa

[Stephan Bergmann (via logerrit)]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 30d2b76e0ed081bed545820e459af56e45fecbdd
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Sun Dec 6 10:27:24 2020 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Sun Dec 6 13:20:35 2020 +0100

    Directly check for nullptr
    
    ...instead of relying on the OString(pText) ctor's undocumented behavior of
    treating a null pText as an empty string
    
    Change-Id: I884c789b9b4c63bc1f013ed6bbf6c3ab9880f0e5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107277
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 701f624038c5..8a5b3f54d81a 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -2738,7 +2738,7 @@ void DesktopLOKTest::testTextSelectionHandles()
     pDocument->pClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYINPUT, 0, com::sun::star::awt::Key::ESCAPE);
     Scheduler::ProcessEventsToIdle();
     pText = pDocument->pClass->getTextSelection(pDocument, "text/plain;charset=utf-8", nullptr);
-    CPPUNIT_ASSERT_EQUAL(OString(), OString(pText));
+    CPPUNIT_ASSERT_EQUAL(static_cast<char *>(nullptr), pText);
     free(pText);
     CPPUNIT_ASSERT_EQUAL(OString(), m_aTextSelectionStart);
     CPPUNIT_ASSERT_EQUAL(OString(), m_aTextSelectionEnd);