[Libreoffice-commits] core.git: xmloff/source

[Noel (via logerrit)]

 xmloff/source/draw/shapeexport.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 1624c674c01fdb2d9ce4a86fa79475224038887e
Author:     Noel <noelgrandin at gmail.com>
AuthorDate: Tue Dec 15 11:47:36 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Dec 15 11:46:19 2020 +0100

    remove assert which crashes ooo119798-1.ppt
    
    with command line
    ./instdir/program/soffice --headless --convert-to odp ooo119798-1.ppt
    
    Added with
        commit 5080bb930de3ecfce8ab78bbd23a9d48c2f2bfa0
        Author: Noel Grandin <noel.grandin at collabora.co.uk>
        Date:   Sat Aug 29 11:19:28 2020 +0200
        convert SvXMLImport to fastparser, drop slowparser paths
    
    which helped me track down a problem, but apparently this happens
    with some broken files
    
    Change-Id: I2866daa2c93ffe01f89120f19e0ea0056ee50605
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107742
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/xmloff/source/draw/shapeexport.cxx b/xmloff/source/draw/shapeexport.cxx
index 8ff9105412ce..7ce06f1edeb7 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -2498,7 +2498,6 @@ void XMLShapeExport::ImpExportControlShape(
         if( xControlModel.is() )
         {
             OUString sControlId = mrExport.GetFormExport()->getControlId( xControlModel );
-            assert(!sControlId.isEmpty());
             mrExport.AddAttribute( XML_NAMESPACE_DRAW, XML_CONTROL, sControlId );
         }
     }