[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - extensions/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Tue Dec 15 17:37:03 UTC 2020


 extensions/source/propctrlr/standardcontrol.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 402316c8df19ec9714a39ff5d7863d03dbe93720
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Dec 15 15:17:27 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Dec 15 18:36:29 2020 +0100

    tdf#138701 leave current combobox cursor valid if the contents won't change
    
    Change-Id: I6d7f5de7b79d447590fcfa325f4be7430eaffd5f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107707
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/extensions/source/propctrlr/standardcontrol.cxx b/extensions/source/propctrlr/standardcontrol.cxx
index 436f5b412e27..c5b03aa270e5 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -587,7 +587,10 @@ namespace pcr
     {
         OUString sText;
         _rValue >>= sText;
-        getTypedControlWindow()->set_entry_text( sText );
+        weld::ComboBox* pControlWindow = getTypedControlWindow();
+        // tdf#138701 leave current cursor valid if the contents won't change
+        if (pControlWindow->get_active_text() != sText)
+            pControlWindow->set_entry_text(sText);
     }
 
     Any SAL_CALL OComboboxControl::getValue()


More information about the Libreoffice-commits mailing list