[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - vcl/unx

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Dec 16 08:47:19 UTC 2020


 vcl/unx/gtk3/gtk3gtkinst.cxx |   12 ++++++++++++
 1 file changed, 12 insertions(+)

New commits:
commit 8a6d2cbbec5d3b779bba9003b482c47a3a1d38c2
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Dec 15 16:35:24 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Dec 16 09:46:39 2020 +0100

    tdf#138661 don't emit value-changed when not changed by user
    
    in the FormattedSpinButton which is the standard mode for these signals
    and what the SpinButton does, and in this case the FormattedSpinButton
    is considered "modified" when it shouldn't be
    
    Change-Id: I26865e099c02fdd2745c41b347b7006d8560fb20
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107710
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index c45a66e9edd4..5e329b541111 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -13054,6 +13054,18 @@ public:
         enable_notify_events();
     }
 
+    virtual void disable_notify_events() override
+    {
+        g_signal_handler_block(m_pButton, m_nValueChangedSignalId);
+        GtkInstanceEntry::disable_notify_events();
+    }
+
+    virtual void enable_notify_events() override
+    {
+        GtkInstanceEntry::enable_notify_events();
+        g_signal_handler_unblock(m_pButton, m_nValueChangedSignalId);
+    }
+
     virtual ~GtkInstanceFormattedSpinButton() override
     {
         g_signal_handler_disconnect(m_pButton, m_nInputSignalId);


More information about the Libreoffice-commits mailing list