[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - vcl/unx

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Thu Dec 17 12:55:29 UTC 2020


 vcl/unx/gtk3/gtk3gtkinst.cxx |   12 ++++++++++++
 1 file changed, 12 insertions(+)

New commits:
commit 5fbd913cf62aa215c66f1f2de47723dc82c83571
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Dec 15 16:35:24 2020 +0000
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Thu Dec 17 13:54:56 2020 +0100

    tdf#138661 don't emit value-changed when not changed by user
    
    in the FormattedSpinButton which is the standard mode for these signals
    and what the SpinButton does, and in this case the FormattedSpinButton
    is considered "modified" when it shouldn't be
    
    Change-Id: I26865e099c02fdd2745c41b347b7006d8560fb20
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107711
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 0290359bebce..b8629d49cbd6 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -12235,6 +12235,18 @@ public:
         enable_notify_events();
     }
 
+    virtual void disable_notify_events() override
+    {
+        g_signal_handler_block(m_pButton, m_nValueChangedSignalId);
+        GtkInstanceEntry::disable_notify_events();
+    }
+
+    virtual void enable_notify_events() override
+    {
+        GtkInstanceEntry::enable_notify_events();
+        g_signal_handler_unblock(m_pButton, m_nValueChangedSignalId);
+    }
+
     virtual ~GtkInstanceFormattedSpinButton() override
     {
         g_signal_handler_disconnect(m_pButton, m_nInputSignalId);


More information about the Libreoffice-commits mailing list