[Libreoffice-commits] core.git: bridges/source

[Stephan Bergmann (via logerrit)]

 bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit d85a3887bf36ff1e4dddb111f2c5634b66eb9510
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Dec 18 12:11:05 2020 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Dec 18 22:01:54 2020 +0100

    Mention relevant Clang bug in comment
    
    Change-Id: I88140ab20440125d9642a1489e501cdcb74c3a48
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107962
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx b/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx
index 77fa3c03bbf4..b31d87655d0c 100644
--- a/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx
@@ -559,7 +559,9 @@ void bridges::cpp_uno::shared::VtableFactory::flushCode(
     // "extend.texi (__clear_cache): Correct signature" that __builtin___clear_cache takes void*
     // parameters, while Clang uses char* ever since
     // <https://github.com/llvm/llvm-project/commit/c491a8d4577052bc6b3b4c72a7db6a7cfcbc2ed0> "Add
-    // support for __builtin___clear_cache in Clang":
+    // support for __builtin___clear_cache in Clang" (TODO: see
+    // <https://bugs.llvm.org/show_bug.cgi?id=48489> "__builtin___clear_cache() has a different
+    // prototype than GCC"; once fixed for our Clang baseline, we can drop the reinterpret_casts):
     __builtin___clear_cache(
         reinterpret_cast<char *>(const_cast<unsigned char *>(begin)),
         reinterpret_cast<char *>(const_cast<unsigned char *>(end)));