[Libreoffice-commits] core.git: cui/uiconfig

[Ming Hua (via logerrit)]

 cui/uiconfig/ui/effectspage.ui |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d70d71d1598297686d420d2f3a0ad1b840d67734
Author:     Ming Hua <plateauwolf at qq.com>
AuthorDate: Thu Nov 26 00:33:49 2020 +0100
Commit:     Heiko Tietze <heiko.tietze at documentfoundation.org>
CommitDate: Mon Dec 28 09:28:17 2020 +0100

    tdf#127611 Hardcode mnemonic key for "Hidden" checkbox
    
    In "Font Effects" tab of the welded Character Format dialog, all
    mnemonics (keyboard accelerators) are automatically generated, except
    the four buttons "Help", "Reset", "OK", and "Cancle" at the bottom.
    Unfortunately the current mnemonic generation mechanism doesn't consider
    these buttons and assign H for "_Hidden", and clashes with "_Help" which
    also uses H.
    
    Ideally the mnemonic generation mechanism should be fixed to consider
    other parts of a welded UI.  Meanwhile this commit provides a workaround
    by hardcoding "Hi_dden" to use D as mnemonic.
    
    Change-Id: Ib59b7ba338be405908f349a22dd8d36ea4ee490b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106670
    Tested-by: Jenkins
    Reviewed-by: Gabor Kelemen <kelemen.gabor2 at nisz.hu>
    Reviewed-by: Heiko Tietze <heiko.tietze at documentfoundation.org>

diff --git a/cui/uiconfig/ui/effectspage.ui b/cui/uiconfig/ui/effectspage.ui
index de23b69c1e89..6bcff5eeaf8b 100644
--- a/cui/uiconfig/ui/effectspage.ui
+++ b/cui/uiconfig/ui/effectspage.ui
@@ -261,7 +261,7 @@
                 </child>
                 <child>
                   <object class="GtkCheckButton" id="hiddencb">
-                    <property name="label" translatable="yes" context="effectspage|hiddencb">Hidden</property>
+                    <property name="label" translatable="yes" context="effectspage|hiddencb">Hi_dden</property>
                     <property name="visible">True</property>
                     <property name="can_focus">True</property>
                     <property name="receives_default">False</property>