[Libreoffice-commits] core.git: sw/uiconfig

Kevin Suo (via logerrit) logerrit at kemper.freedesktop.org
Mon Dec 28 08:34:10 UTC 2020


 sw/uiconfig/swriter/ui/flddocinfopage.ui |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4987c82449183d47464c94d4ed0aa0bbf2abf3aa
Author:     Kevin Suo <suokunlong at 126.com>
AuthorDate: Thu Dec 24 18:55:46 2020 +0800
Commit:     Heiko Tietze <heiko.tietze at documentfoundation.org>
CommitDate: Mon Dec 28 09:33:33 2020 +0100

    tdf#104278: text in Type frame in DocInformation is not aligned left
    
    As we can see from sw/uiconfig/swriter/ui/flddocinfopage.ui, we have a GtkTreeView in GtkFrame "typeframe", without the following property:
    <property name="show_expanders">False</property>
    
    A GtkTreeView seems have a default indentation if show_expanders is True (which is the default), see:
    https://developer.gnome.org/gtk3/stable/GtkTreeView.html#gtk-tree-view-set-show-expanders
    
    A "expander" would look like this: https://python-gtk-3-tutorial.readthedocs.io/en/latest/expander.html
    
    I do not see a reason why we should use an expander here in this dialog. As a result, setting show_expanders to False will solve the problem.
    
    Change-Id: I29cbb13f8d57aeb502079f278e4b620d97d8f170
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108261
    Tested-by: Jenkins
    Reviewed-by: Heiko Tietze <heiko.tietze at documentfoundation.org>

diff --git a/sw/uiconfig/swriter/ui/flddocinfopage.ui b/sw/uiconfig/swriter/ui/flddocinfopage.ui
index f45ef7350295..13054b693681 100644
--- a/sw/uiconfig/swriter/ui/flddocinfopage.ui
+++ b/sw/uiconfig/swriter/ui/flddocinfopage.ui
@@ -64,6 +64,7 @@
                     <property name="headers_visible">False</property>
                     <property name="headers_clickable">False</property>
                     <property name="search_column">0</property>
+                    <property name="show_expanders">False</property>
                     <child internal-child="selection">
                       <object class="GtkTreeSelection" id="treeview-selection1"/>
                     </child>


More information about the Libreoffice-commits mailing list