[Libreoffice-commits] core.git: vcl/jsdialog

Henry Castro (via logerrit) logerrit at kemper.freedesktop.org
Mon Dec 28 12:26:10 UTC 2020


 vcl/jsdialog/executor.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5a8c379642358f66a6e921e8da746d845ebcd7f6
Author:     Henry Castro <hcastro at collabora.com>
AuthorDate: Fri Dec 18 08:05:12 2020 -0400
Commit:     Henry Castro <hcastro at collabora.com>
CommitDate: Mon Dec 28 13:25:17 2020 +0100

    jsdialog: disable row activated on "select" action
    
    Unfortunately, when the "Macro Selector Dialog" is shown
    and issue the "select" action, it closes the dialog
    because the row activated trigger double click the macro
    selected.
    
    for moment comment the unexpected side effect
    
    Change-Id: Ibdfa09c444ee79376a9e2251e919f5f06dba577d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107964
    Tested-by: Jenkins
    Reviewed-by: Henry Castro <hcastro at collabora.com>

diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index 775879c54f69..933149efde05 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -208,7 +208,7 @@ bool ExecuteAction(sal_uInt64 nWindowId, const OString& rWidget, StringMap& rDat
                     pTreeView->select(nRow);
                     pTreeView->set_cursor(nRow);
                     LOKTrigger::trigger_changed(*pTreeView);
-                    LOKTrigger::trigger_row_activated(*pTreeView);
+                    //LOKTrigger::trigger_row_activated(*pTreeView);
                     return true;
                 }
                 else if (sAction == "expand")


More information about the Libreoffice-commits mailing list