[Libreoffice-commits] core.git: include/svx

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Mon Feb 3 13:48:23 UTC 2020


 include/svx/transfrmhelper.hxx |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit c98eb95249e73ee4341f21f6406dd8a8cda51960
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Mon Feb 3 13:04:08 2020 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Mon Feb 3 14:47:41 2020 +0100

    Change class with only static member functions into namespace
    
    ...and drop the SVX_DLLPUBLIC as all the functions are inline.  (The class had
    introduced as SVX_DLLPUBLIC with 1386c348f81738a9966d1217db89d1f603466317
    "fdo#82616: set limits on spinboxes according to size of workarea", but for no
    obvious reason.  It now showed up among the "10 @@@ [that] ask for follow-up
    clean up" at ff546a5dd35d6a31f01c70a9b995afc1f7b7389e "tdf#128302: Split
    SVXCORE_DLLPUBLIC from SVX_DLLPUBLIC".)
    
    Change-Id: I366b19d596da7cf44a192b1faf47e8ea75d25685
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87860
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/include/svx/transfrmhelper.hxx b/include/svx/transfrmhelper.hxx
index 19ddbfa158c3..0c9b7e958107 100644
--- a/include/svx/transfrmhelper.hxx
+++ b/include/svx/transfrmhelper.hxx
@@ -21,16 +21,14 @@
 #define INCLUDED_SVX_TRANSFRMHELPER_HXX
 
 #include <basegfx/range/b2drange.hxx>
-#include <svx/svxdllapi.h>
 #include <tools/fract.hxx>
 #include <tools/fldunit.hxx>
 #include <tools/mapunit.hxx>
 #include <vcl/field.hxx>
 
-class SVX_DLLPUBLIC TransfrmHelper
+namespace TransfrmHelper
 {
-public:
-    static void ConvertRect(basegfx::B2DRange& rRange, const sal_uInt16 nDigits, const MapUnit ePoolUnit, const FieldUnit eDlgUnit)
+    inline void ConvertRect(basegfx::B2DRange& rRange, const sal_uInt16 nDigits, const MapUnit ePoolUnit, const FieldUnit eDlgUnit)
     {
         const basegfx::B2DPoint aTopLeft(
             static_cast<double>(MetricField::ConvertValue(basegfx::fround(rRange.getMinX()), nDigits, ePoolUnit, eDlgUnit)),
@@ -42,12 +40,12 @@ public:
         rRange = basegfx::B2DRange(aTopLeft, aBottomRight);
     }
 
-    static void ScaleRect(basegfx::B2DRange& rRange, const Fraction& rUIScale)
+    inline void ScaleRect(basegfx::B2DRange& rRange, const Fraction& rUIScale)
     {
         const double fFactor(1.0 / double(rUIScale));
         rRange = basegfx::B2DRange(rRange.getMinimum() * fFactor, rRange.getMaximum() * fFactor);
     }
-};
+}
 
 #endif
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


More information about the Libreoffice-commits mailing list