[Libreoffice-commits] core.git: embeddedobj/test include/editeng include/salhelper

Shivam Kumar Singh (via logerrit) logerrit at kemper.freedesktop.org
Tue Feb 4 17:27:55 UTC 2020


 embeddedobj/test/Container1/nativelib/nativeview.c |    2 +-
 include/editeng/svxfont.hxx                        |    2 +-
 include/salhelper/timer.hxx                        |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 03685b1ab86a9b8d78ad2a4fd460c2aaa50f03ab
Author:     Shivam Kumar Singh <shivamhere247 at gmail.com>
AuthorDate: Wed Jan 15 14:44:44 2020 +0530
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Feb 4 18:27:25 2020 +0100

    tdf#96505 Get rid of cargo cult "long" integer literals .
    
    In some places the integers end with L which denotes that the number is in long long format.
    This representation was not required .
    
    Change-Id: Ia8ae328ee943780ccbfb7ce15013f3ac0365a3db
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86842
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
    Tested-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/embeddedobj/test/Container1/nativelib/nativeview.c b/embeddedobj/test/Container1/nativelib/nativeview.c
index 29dd49437e0b..9d0f478bd410 100644
--- a/embeddedobj/test/Container1/nativelib/nativeview.c
+++ b/embeddedobj/test/Container1/nativelib/nativeview.c
@@ -34,7 +34,7 @@ static LRESULT APIENTRY NativeViewWndProc( HWND , UINT , WPARAM , LPARAM );
 #include "jawt_md.h"
 #include "NativeView.h"
 
-#define MY_ASSERT(X,S) if (!X) { fprintf(stderr,"%s\n",S); return 0L;}
+#define MY_ASSERT(X,S) if (!X) { fprintf(stderr,"%s\n",S); return 0;}
 
 #define SYSTEM_WIN32   1
 #define SYSTEM_WIN16   2
diff --git a/include/editeng/svxfont.hxx b/include/editeng/svxfont.hxx
index cf8862da0a9d..b584bb842b4d 100644
--- a/include/editeng/svxfont.hxx
+++ b/include/editeng/svxfont.hxx
@@ -53,7 +53,7 @@ public:
     sal_uInt8 GetPropr() const { return nPropr; }
     void SetPropr( const sal_uInt8 nNewPropr ) { nPropr = nNewPropr; }
     void SetProprRel( const sal_uInt8 nNewPropr )
-        { SetPropr( static_cast<sal_uInt8>( static_cast<long>(nNewPropr) * static_cast<long>(nPropr) / 100L ) ); }
+        { SetPropr( static_cast<sal_uInt8>( static_cast<long>(nNewPropr) * static_cast<long>(nPropr) / 100 ) ); }
 
     // Kerning
     short GetFixKerning() const { return nKern; }
diff --git a/include/salhelper/timer.hxx b/include/salhelper/timer.hxx
index 440790432f59..f6e67f454270 100644
--- a/include/salhelper/timer.hxx
+++ b/include/salhelper/timer.hxx
@@ -50,7 +50,7 @@ struct SAL_WARN_UNUSED TTimeValue : public TimeValue
 
     TTimeValue(sal_uInt32 MilliSecs)
     {
-        Seconds = MilliSecs / 1000L;
+        Seconds = MilliSecs / 1000;
         Nanosec = (MilliSecs % 1000) * 1000000L;
 
         normalize();


More information about the Libreoffice-commits mailing list