[Libreoffice-commits] core.git: compilerplugins/clang include/sfx2 include/svtools sfx2/source svtools/source svx/source
Noel Grandin (via logerrit)
logerrit at kemper.freedesktop.org
Fri Feb 7 06:19:21 UTC 2020
compilerplugins/clang/unusedmethods.results | 46 +++++---
include/sfx2/sidebar/AsynchronousCall.hxx | 1
include/svtools/valueset.hxx | 11 -
sfx2/source/sidebar/AsynchronousCall.cxx | 6 -
svtools/source/control/valueset.cxx | 153 ---------------------------
svx/source/dialog/ClassificationEditView.hxx | 4
6 files changed, 30 insertions(+), 191 deletions(-)
New commits:
commit c19e688b1a1c3165e267eea971892869edb89569
Author: Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Feb 6 11:44:26 2020 +0200
Commit: Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Feb 7 07:18:48 2020 +0100
loplugin:unusedmethods
Change-Id: I7296b2fc2862d0ad1f68658b19b2a25cb7609df1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88080
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results
index 5c9cda42b90e..3f1635f5f34d 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -84,12 +84,16 @@ cui/source/inc/cfgutil.hxx:143
_Bool CuiConfigFunctionListBox::get_iter_first(class weld::TreeIter &) const
cui/source/inc/cfgutil.hxx:145
_Bool CuiConfigFunctionListBox::iter_next(class weld::TreeIter &) const
+cui/source/inc/cfgutil.hxx:146
+ _Bool CuiConfigFunctionListBox::iter_next_sibling(class weld::TreeIter &) const
cui/source/inc/cfgutil.hxx:148
class rtl::OUString CuiConfigFunctionListBox::get_text(const class weld::TreeIter &) const
cui/source/inc/cfgutil.hxx:151
class rtl::OUString CuiConfigFunctionListBox::get_id(int) const
cui/source/inc/cfgutil.hxx:165
int CuiConfigFunctionListBox::get_selected_index() const
+cui/source/inc/cfgutil.hxx:166
+ void CuiConfigFunctionListBox::select(const class weld::TreeIter &)
cui/source/inc/CustomNotebookbarGenerator.hxx:31
CustomNotebookbarGenerator::CustomNotebookbarGenerator()
cui/source/inc/hangulhanjadlg.hxx:244
@@ -608,6 +612,8 @@ include/sfx2/lokcharthelper.hxx:42
void LokChartHelper::Invalidate()
include/sfx2/msg.hxx:120
const class std::type_info * SfxType0::Type() const
+include/sfx2/sidebar/AsynchronousCall.hxx:37
+ sfx2::sidebar::AsynchronousCall::AsynchronousCall()
include/svl/itempool.hxx:171
const type-parameter-?-? * SfxItemPool::GetItem2Default(TypedWhichId<type-parameter-?-?>) const
include/svl/itempool.hxx:207
@@ -622,24 +628,32 @@ include/svtools/toolbarmenu.hxx:112
class weld::Container * ToolbarPopupContainer::getContainer()
include/svtools/toolbarmenu.hxx:129
class weld::Container * InterimToolbarPopup::getContainer()
-include/svtools/valueset.hxx:251
- _Bool ValueSet::ImplScroll(const class Point &)
-include/svtools/valueset.hxx:263
- void ValueSet::LinkStubImplTimerHdl(void *,class Timer *)
+include/svtools/valueset.hxx:301
+ void ValueSet::RemoveItem(unsigned short)
+include/svtools/valueset.hxx:332
+ void ValueSet::SetItemImage(unsigned short,const class Image &)
+include/svtools/valueset.hxx:333
+ class Image ValueSet::GetItemImage(unsigned short) const
+include/svtools/valueset.hxx:335
+ void ValueSet::SetItemData(unsigned short,void *)
+include/svtools/valueset.hxx:336
+ void * ValueSet::GetItemData(unsigned short) const
+include/svtools/valueset.hxx:337
+ void ValueSet::SetItemText(unsigned short,const class rtl::OUString &)
+include/svtools/valueset.hxx:339
+ void ValueSet::SetColor(const class Color &)
+include/svtools/valueset.hxx:345
+ void ValueSet::SetExtraSpacing(unsigned short)
+include/svtools/valueset.hxx:347
+ void ValueSet::SetFormat()
include/svx/autoformathelper.hxx:145
_Bool AutoFormatBase::operator==(const class AutoFormatBase &)
include/svx/ClassificationDialog.hxx:77
void svx::ClassificationDialog::(anonymous)::__invoke()
-include/svx/ClassificationEditView.hxx:38
- void svx::ClassificationEditView::SetCharAttributes()
-include/svx/ClassificationEditView.hxx:44
- void svx::ClassificationEditView::SetNumType(enum SvxNumType)
include/svx/ClassificationField.hxx:47
const class rtl::OUString & svx::ClassificationResult::getDisplayText() const
include/svx/ClassificationField.hxx:52
_Bool svx::ClassificationResult::operator==(const class svx::ClassificationResult &) const
-include/svx/colorwindow.hxx:101
- _Bool SvxColorWindow::IsNoSelection() const
include/svx/DiagramDataInterface.hxx:33
class rtl::OUString DiagramDataInterface::getString() const
include/svx/dlgctrl.hxx:257
@@ -766,8 +780,6 @@ include/vcl/animate/AnimationBitmap.hxx:69
_Bool AnimationBitmap::operator!=(const struct AnimationBitmap &) const
include/vcl/BitmapColor.hxx:39
void BitmapColor::SetAlpha(unsigned char)
-include/vcl/builder.hxx:410
- enum FieldUnit BuilderUtils::detectUnit(const class rtl::OUString &)
include/vcl/builderpage.hxx:36
void BuilderPage::SetHelpId(const class rtl::OString &)
include/vcl/ColorMask.hxx:113
@@ -986,10 +998,10 @@ libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:73
void ::operator()(struct _GtkBuilder *) const
libreofficekit/qa/gtktiledviewer/gtv-comments-sidebar.cxx:32
void * gtv_comments_sidebar_get_instance_private(struct GtvCommentsSidebar *)
+libreofficekit/qa/gtktiledviewer/gtv-comments-sidebar.cxx:50
+ void ::operator()(struct _GList *) const
libreofficekit/qa/gtktiledviewer/gtv-helpers.cxx:77
void ::operator()(struct _GtkTargetList *) const
-libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx:183
- void ::operator()(struct _GList *) const
libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.hxx:35
void openLokDialog(struct _GtkWidget *,void *)
lotuswordpro/source/filter/clone.hxx:28
@@ -1352,6 +1364,10 @@ svl/source/misc/gridprinter.cxx:47
void rtl::mdds_mtv_append_values(struct mdds::mtv::base_element_block &,const class rtl::OUString &,const type-parameter-?-? &,const type-parameter-?-? &)
svx/inc/sdr/contact/viewcontactofgraphic.hxx:54
class SdrGrafObj & sdr::contact::ViewContactOfGraphic::GetGrafObject()
+svx/source/dialog/ClassificationEditView.hxx:38
+ void svx::ClassificationEditView::SetCharAttributes()
+svx/source/dialog/ClassificationEditView.hxx:44
+ void svx::ClassificationEditView::SetNumType(enum SvxNumType)
svx/source/svdraw/svdpdf.hxx:89
double ImpSdrPdfImport::Matrix::b() const
svx/source/svdraw/svdpdf.hxx:91
@@ -1684,8 +1700,6 @@ vcl/inc/skia/salbmp.hxx:69
void SkiaSalBitmap::dump(const char *) const
vcl/inc/skia/utils.hxx:47
void SkiaHelper::dump(const class SkBitmap &,const char *)
-vcl/inc/slider.hxx:97
- void Slider::SetScrollTypeSet(_Bool)
vcl/inc/unx/glyphcache.hxx:108
void FreetypeManager::ClearFontOptions()
vcl/inc/unx/gtk/gtkframe.hxx:216
diff --git a/include/sfx2/sidebar/AsynchronousCall.hxx b/include/sfx2/sidebar/AsynchronousCall.hxx
index b2c868b653ec..98c4c75602a4 100644
--- a/include/sfx2/sidebar/AsynchronousCall.hxx
+++ b/include/sfx2/sidebar/AsynchronousCall.hxx
@@ -34,7 +34,6 @@ class AsynchronousCall
public:
typedef ::std::function<void()> Action;
- AsynchronousCall();
AsynchronousCall (const Action& rAction);
~AsynchronousCall();
diff --git a/include/svtools/valueset.hxx b/include/svtools/valueset.hxx
index 342d80a615db..7d31ab07e83d 100644
--- a/include/svtools/valueset.hxx
+++ b/include/svtools/valueset.hxx
@@ -298,7 +298,6 @@ public:
const OUString& rStr);
/// Insert an User Drawn item.
void InsertItem(sal_uInt16 nItemId, size_t nPos = VALUESET_APPEND);
- void RemoveItem(sal_uInt16 nItemId);
void Clear();
@@ -329,23 +328,13 @@ public:
return mbNoSelection;
}
- void SetItemImage( sal_uInt16 nItemId, const Image& rImage );
- Image GetItemImage( sal_uInt16 nItemId ) const;
Color GetItemColor( sal_uInt16 nItemId ) const;
- void SetItemData( sal_uInt16 nItemId, void* pData );
- void* GetItemData( sal_uInt16 nItemId ) const;
- void SetItemText( sal_uInt16 nItemId, const OUString& rStr );
OUString GetItemText( sal_uInt16 nItemId ) const;
- void SetColor( const Color& rColor );
bool IsColor() const
{
return maColor.GetTransparency() == 0;
}
- void SetExtraSpacing( sal_uInt16 nNewSpacing );
-
- void SetFormat();
-
void EndSelection();
Size CalcWindowSizePixel(const Size& rItemSize,
diff --git a/sfx2/source/sidebar/AsynchronousCall.cxx b/sfx2/source/sidebar/AsynchronousCall.cxx
index 151accc5d543..5a3ce8db240d 100644
--- a/sfx2/source/sidebar/AsynchronousCall.cxx
+++ b/sfx2/source/sidebar/AsynchronousCall.cxx
@@ -22,12 +22,6 @@
namespace sfx2::sidebar {
-AsynchronousCall::AsynchronousCall()
- : maAction(),
- mnCallId(nullptr)
-{
-}
-
AsynchronousCall::AsynchronousCall (const Action& rAction)
: maAction(rAction),
mnCallId(nullptr)
diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index e29502143e45..299ee0209557 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -1471,33 +1471,6 @@ tools::Rectangle ValueSet::ImplGetItemRect( size_t nPos ) const
return tools::Rectangle( Point(x, y), Size(mnItemWidth, mnItemHeight) );
}
-void ValueSet::RemoveItem( sal_uInt16 nItemId )
-{
- size_t nPos = GetItemPos( nItemId );
-
- if ( nPos == VALUESET_ITEM_NOTFOUND )
- return;
-
- if ( nPos < mItemList.size() ) {
- mItemList.erase( mItemList.begin() + nPos );
- }
-
- // reset variables
- if ( (mnHighItemId == nItemId) || (mnSelItemId == nItemId) )
- {
- mnCurCol = 0;
- mnHighItemId = 0;
- mnSelItemId = 0;
- mbNoSelection = true;
- }
-
- queue_resize();
-
- mbFormat = true;
- if ( IsReallyVisible() && IsUpdateMode() )
- Invalidate();
-}
-
void ValueSet::Clear()
{
ImplDeleteItems();
@@ -1712,36 +1685,6 @@ void ValueSet::SetNoSelection()
Invalidate();
}
-void ValueSet::SetItemImage( sal_uInt16 nItemId, const Image& rImage )
-{
- size_t nPos = GetItemPos( nItemId );
-
- if ( nPos == VALUESET_ITEM_NOTFOUND )
- return;
-
- ValueSetItem* pItem = mItemList[nPos].get();
- pItem->meType = VALUESETITEM_IMAGE;
- pItem->maImage = rImage;
-
- if ( !mbFormat && IsReallyVisible() && IsUpdateMode() )
- {
- const tools::Rectangle aRect = ImplGetItemRect(nPos);
- Invalidate(aRect);
- }
- else
- mbFormat = true;
-}
-
-Image ValueSet::GetItemImage( sal_uInt16 nItemId ) const
-{
- size_t nPos = GetItemPos( nItemId );
-
- if ( nPos != VALUESET_ITEM_NOTFOUND )
- return mItemList[nPos]->maImage;
- else
- return Image();
-}
-
Color ValueSet::GetItemColor( sal_uInt16 nItemId ) const
{
size_t nPos = GetItemPos( nItemId );
@@ -1752,76 +1695,6 @@ Color ValueSet::GetItemColor( sal_uInt16 nItemId ) const
return Color();
}
-void ValueSet::SetItemData( sal_uInt16 nItemId, void* pData )
-{
- size_t nPos = GetItemPos( nItemId );
-
- if ( nPos == VALUESET_ITEM_NOTFOUND )
- return;
-
- ValueSetItem* pItem = mItemList[nPos].get();
- pItem->mpData = pData;
-
- if ( pItem->meType == VALUESETITEM_USERDRAW )
- {
- if ( !mbFormat && IsReallyVisible() && IsUpdateMode() )
- {
- const tools::Rectangle aRect = ImplGetItemRect(nPos);
- Invalidate(aRect);
- }
- else
- mbFormat = true;
- }
-}
-
-void* ValueSet::GetItemData( sal_uInt16 nItemId ) const
-{
- size_t nPos = GetItemPos( nItemId );
-
- if ( nPos != VALUESET_ITEM_NOTFOUND )
- return mItemList[nPos]->mpData;
- else
- return nullptr;
-}
-
-void ValueSet::SetItemText(sal_uInt16 nItemId, const OUString& rText)
-{
- size_t nPos = GetItemPos( nItemId );
-
- if ( nPos == VALUESET_ITEM_NOTFOUND )
- return;
-
-
- ValueSetItem* pItem = mItemList[nPos].get();
- if (pItem->maText == rText)
- return;
- // Remember old and new name for accessibility event.
- Any aOldName;
- Any aNewName;
- aOldName <<= pItem->maText;
- aNewName <<= rText;
-
- pItem->maText = rText;
-
- if (!mbFormat && IsReallyVisible() && IsUpdateMode())
- {
- sal_uInt16 nTempId = mnSelItemId;
-
- if (mbHighlight)
- nTempId = mnHighItemId;
-
- if (nTempId == nItemId)
- Invalidate();
- }
-
- if (ImplHasAccessibleListeners())
- {
- Reference<XAccessible> xAccessible(pItem->GetAccessible( false/*bIsTransientChildrenDisabled*/));
- ValueItemAcc* pValueItemAcc = static_cast<ValueItemAcc*>(xAccessible.get());
- pValueItemAcc->FireAccessibleEvent(AccessibleEventId::NAME_CHANGED, aOldName, aNewName);
- }
-}
-
OUString ValueSet::GetItemText( sal_uInt16 nItemId ) const
{
size_t nPos = GetItemPos( nItemId );
@@ -1832,27 +1705,6 @@ OUString ValueSet::GetItemText( sal_uInt16 nItemId ) const
return OUString();
}
-void ValueSet::SetColor( const Color& rColor )
-{
- maColor = rColor;
- mbFormat = true;
- if (IsReallyVisible() && IsUpdateMode())
- Invalidate();
-}
-
-void ValueSet::SetExtraSpacing( sal_uInt16 nNewSpacing )
-{
- if ( GetStyle() & WB_ITEMBORDER )
- {
- mnSpacing = nNewSpacing;
-
- mbFormat = true;
- queue_resize();
- if ( IsReallyVisible() && IsUpdateMode() )
- Invalidate();
- }
-}
-
void ValueSet::EndSelection()
{
if ( mbHighlight )
@@ -1865,11 +1717,6 @@ void ValueSet::EndSelection()
}
}
-void ValueSet::SetFormat()
-{
- mbFormat = true;
-}
-
Size ValueSet::CalcWindowSizePixel( const Size& rItemSize, sal_uInt16 nDesireCols,
sal_uInt16 nDesireLines ) const
{
diff --git a/svx/source/dialog/ClassificationEditView.hxx b/svx/source/dialog/ClassificationEditView.hxx
index 8c30518b1816..dda6e8aff6e3 100644
--- a/svx/source/dialog/ClassificationEditView.hxx
+++ b/svx/source/dialog/ClassificationEditView.hxx
@@ -35,14 +35,10 @@ public:
virtual void makeEditEngine() override;
- void SetCharAttributes();
-
void InsertField(const SvxFieldItem& rField);
void InvertSelectionWeight();
- void SetNumType(SvxNumType eNumType);
-
ClassificationEditEngine& getEditEngine()
{
return *static_cast<ClassificationEditEngine*>(m_xEditEngine.get());
More information about the Libreoffice-commits
mailing list