[Libreoffice-commits] core.git: basctl/source

[Caolán McNamara (via logerrit)]

 basctl/source/basicide/basidesh.cxx |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit a07f0a57378a8901d647e3e5de8347445a82ea17
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Feb 7 17:11:38 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Feb 7 22:38:05 2020 +0100

    property browser appearing as a blank area when changing modules
    
    under gtk, so just don't create it until we need it
    
    Change-Id: I0fd86c6b587788c42646a107746e8e4e10f2a13f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88230
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/basctl/source/basicide/basidesh.cxx b/basctl/source/basicide/basidesh.cxx
index 2c6f6424baa1..0b9a2eaf88b8 100644
--- a/basctl/source/basicide/basidesh.cxx
+++ b/basctl/source/basicide/basidesh.cxx
@@ -697,14 +697,15 @@ void Shell::UpdateWindows()
                             for ( sal_Int32 j = 0 ; j < nDlgCount ; j++ )
                             {
                                 OUString aDlgName = pDlgNames[ j ];
-                                // this find only looks for non-suspended windows;
-                                // suspended windows are handled in CreateDlgWin
-                                VclPtr<DialogWindow> pWin = FindDlgWin( doc, aLibName, aDlgName );
-                                if ( !pWin )
-                                    pWin = CreateDlgWin( doc, aLibName, aDlgName );
                                 if ( !pNextActiveWindow && pLibInfoItem && pLibInfoItem->GetCurrentName() == aDlgName &&
                                      pLibInfoItem->GetCurrentType() == TYPE_DIALOG )
                                 {
+                                    // this find only looks for non-suspended windows;
+                                    // suspended windows are handled in CreateDlgWin
+                                    VclPtr<DialogWindow> pWin = FindDlgWin( doc, aLibName, aDlgName );
+                                    if ( !pWin )
+                                        pWin = CreateDlgWin( doc, aLibName, aDlgName );
+
                                     pNextActiveWindow = pWin;
                                 }
                             }