[Libreoffice-commits] core.git: include/vcl vcl/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Tue Feb 11 08:57:51 UTC 2020


 include/vcl/splitwin.hxx       |    1 -
 vcl/source/window/splitwin.cxx |   19 -------------------
 2 files changed, 20 deletions(-)

New commits:
commit ac361231fecb281a0e9550a6527d39183480fe29
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Feb 11 09:44:26 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Feb 11 09:57:15 2020 +0100

    SplitWindow::ImplDrawBack is effectively unused
    
    ever since
        commit facc94bb0aef58353d54e14f948790643ccbec32
        Date:   Thu Jan 30 14:36:57 2020 +0200
        loplugin:unusedfields
    
    Change-Id: Idb09424a09074abe77d6d5b63ea4a526a3bb7ed2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88423
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/include/vcl/splitwin.hxx b/include/vcl/splitwin.hxx
index 022695e3f2f6..49d08d644e39 100644
--- a/include/vcl/splitwin.hxx
+++ b/include/vcl/splitwin.hxx
@@ -100,7 +100,6 @@ private:
     SAL_DLLPRIVATE void ImplDrawBorderLine(vcl::RenderContext& rRenderContext);
     static SAL_DLLPRIVATE void ImplCalcSet2( SplitWindow* pWindow, ImplSplitSet* pSet, bool bHide,
                                              bool bRows );
-    SAL_DLLPRIVATE void ImplDrawBack(vcl::RenderContext& rRenderContext, ImplSplitSet* pSet );
     static SAL_DLLPRIVATE sal_uInt16 ImplTestSplit( ImplSplitSet* pSet, const Point& rPos,
                                                 long& rMouseOff, ImplSplitSet** ppFoundSet, sal_uInt16& rFoundPos,
                                                 bool bRows );
diff --git a/vcl/source/window/splitwin.cxx b/vcl/source/window/splitwin.cxx
index 7f48142f6a54..b6d4e96f16d4 100644
--- a/vcl/source/window/splitwin.cxx
+++ b/vcl/source/window/splitwin.cxx
@@ -845,22 +845,6 @@ static void ImplCalcLogSize( std::vector< ImplSplitItem > & rItems, size_t nItem
     }
 }
 
-void SplitWindow::ImplDrawBack(vcl::RenderContext& rRenderContext, ImplSplitSet* pSet)
-{
-    std::vector< ImplSplitItem >& rItems = pSet->mvItems;
-
-    for ( const auto& rItem : rItems )
-    {
-        pSet = rItem.mpSet.get();
-    }
-
-    for ( auto& rItem : rItems )
-    {
-        if (rItem.mpSet)
-            ImplDrawBack(rRenderContext, rItem.mpSet.get());
-    }
-}
-
 static void ImplDrawSplit(vcl::RenderContext& rRenderContext, ImplSplitSet* pSet, bool bRows, bool bDown)
 {
     if (pSet->mvItems.empty())
@@ -2113,9 +2097,6 @@ void SplitWindow::Paint(vcl::RenderContext& rRenderContext, const tools::Rectang
     ImplDrawFadeOut(rRenderContext);
     ImplDrawFadeIn(rRenderContext);
 
-    // draw FrameSet-backgrounds
-    ImplDrawBack(rRenderContext, mpMainSet.get());
-
     // draw splitter
     if (!(mnWinStyle & WB_NOSPLITDRAW))
     {


More information about the Libreoffice-commits mailing list